diff options
| author | Henning Baldersheim <balder@yahoo-inc.com> | 2023-09-02 17:49:06 +0200 |
|---|---|---|
| committer | Henning Baldersheim <balder@yahoo-inc.com> | 2023-09-03 16:32:28 +0200 |
| commit | 01ed2064f931d598a35c2bf5083df5b8e071e5aa (patch) | |
| tree | 40940752d633e80f7d32b236d9f9c8387edecf3a /node-admin | |
| parent | 66528789e10fae1f95ceecdfb4eddccad814d97f (diff) | |
- Avoid single use of google's EqualsTester
- GC all references to unused packages.
Diffstat (limited to 'node-admin')
| -rw-r--r-- | node-admin/pom.xml | 5 | ||||
| -rw-r--r-- | node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/network/VersionedIpAddressTest.java | 20 |
2 files changed, 13 insertions, 12 deletions
diff --git a/node-admin/pom.xml b/node-admin/pom.xml index cf45e010d14..d24ff9a3655 100644 --- a/node-admin/pom.xml +++ b/node-admin/pom.xml @@ -86,11 +86,6 @@ <!-- Test --> <dependency> - <groupId>com.google.guava</groupId> - <artifactId>guava-testlib</artifactId> - <scope>test</scope> - </dependency> - <dependency> <groupId>org.mockito</groupId> <artifactId>mockito-core</artifactId> <scope>test</scope> diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/network/VersionedIpAddressTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/network/VersionedIpAddressTest.java index 32fbcf9f6a4..79664159b88 100644 --- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/network/VersionedIpAddressTest.java +++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/task/util/network/VersionedIpAddressTest.java @@ -1,12 +1,12 @@ package com.yahoo.vespa.hosted.node.admin.task.util.network; -import com.google.common.testing.EqualsTester; import org.junit.jupiter.api.Test; import java.util.List; import java.util.stream.Stream; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotEquals; /** * @author gjoranv @@ -51,12 +51,18 @@ public class VersionedIpAddressTest { @Test void equals_and_hashCode_are_implemented() { - new EqualsTester() - .addEqualityGroup(VersionedIpAddress.from("::1"), VersionedIpAddress.from("::1")) - .addEqualityGroup(VersionedIpAddress.from("::2")) - .addEqualityGroup(VersionedIpAddress.from("127.0.0.1"), VersionedIpAddress.from("127.0.0.1")) - .addEqualityGroup(VersionedIpAddress.from("10.0.0.1")) - .testEquals(); + var one = VersionedIpAddress.from("::1"); + var two = VersionedIpAddress.from("::2"); + var local = VersionedIpAddress.from("127.0.0.1"); + var ten = VersionedIpAddress.from("10.0.0.1"); + assertEquals(one, VersionedIpAddress.from("::1")); + assertNotEquals(one, two); + assertNotEquals(one, local); + assertNotEquals(one, ten); + + assertEquals(local, VersionedIpAddress.from("127.0.0.1")); + assertNotEquals(local, two); + assertNotEquals(local, 10); } } |