diff options
author | Valerij Fredriksen <valerijf@oath.com> | 2017-09-22 10:11:24 +0200 |
---|---|---|
committer | Valerij Fredriksen <valerijf@oath.com> | 2017-09-22 10:11:24 +0200 |
commit | 383fc35d456ef7c58901da664426e6a1e274aa75 (patch) | |
tree | a1dc57fbbc14519df4fc5c25f49d1e2a3f378ce3 /node-admin | |
parent | 336758a654cafaf193432c52f71b462ca7d42590 (diff) |
Put acquire lock before try block
Diffstat (limited to 'node-admin')
-rw-r--r-- | node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/provider/NodeAdminProvider.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/provider/NodeAdminProvider.java b/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/provider/NodeAdminProvider.java index 632bab5135d..5536ee1551b 100644 --- a/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/provider/NodeAdminProvider.java +++ b/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/provider/NodeAdminProvider.java @@ -46,13 +46,13 @@ public class NodeAdminProvider implements Provider<NodeAdminStateUpdater> { private final Logger log = Logger.getLogger(NodeAdminProvider.class.getName()); private final NodeAdminStateUpdater nodeAdminStateUpdater; - private Lock classLock = null; + private final Lock classLock; @Inject public NodeAdminProvider(Docker docker, MetricReceiverWrapper metricReceiver, Locking locking) { log.log(LogLevel.INFO, objectToString() + ": Creating object, acquiring lock..."); + classLock = locking.lock(this.getClass()); try { - classLock = locking.lock(this.getClass()); log.log(LogLevel.INFO, objectToString() + ": Lock acquired"); Clock clock = Clock.systemUTC(); @@ -78,7 +78,7 @@ public class NodeAdminProvider implements Provider<NodeAdminStateUpdater> { dockerHostHostName, clock, NODE_ADMIN_CONVERGE_STATE_INTERVAL); nodeAdminStateUpdater.start(); } catch (Exception e) { - if (classLock != null) classLock.close(); + classLock.close(); throw e; } } |