summaryrefslogtreecommitdiffstats
path: root/node-admin
diff options
context:
space:
mode:
authorValerij Fredriksen <valerijf@oath.com>2018-11-14 13:24:57 +0100
committerValerij Fredriksen <valerijf@oath.com>2018-11-14 13:24:57 +0100
commit9b6a78ddec7060d57a1e5cade4e9f0fffe0aceca (patch)
tree784ae72716e26c669de292c42cf28aff1451279d /node-admin
parent58381506bcc89c8d91b5a3a4890e30a4d3c6ea90 (diff)
Do not set VESPA_CONFIGSERVERS in DockerOperations
Diffstat (limited to 'node-admin')
-rw-r--r--node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/docker/DockerOperationsImpl.java8
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/docker/DockerOperationsImplTest.java3
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/integrationTests/DockerTester.java3
3 files changed, 3 insertions, 11 deletions
diff --git a/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/docker/DockerOperationsImpl.java b/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/docker/DockerOperationsImpl.java
index b27e2033834..f0a5b6a061e 100644
--- a/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/docker/DockerOperationsImpl.java
+++ b/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/docker/DockerOperationsImpl.java
@@ -46,14 +46,11 @@ public class DockerOperationsImpl implements DockerOperations {
private final Docker docker;
private final ProcessExecuter processExecuter;
- private final List<String> configServerHostnames;
private final IPAddresses ipAddresses;
- public DockerOperationsImpl(Docker docker, ProcessExecuter processExecuter,
- List<String> configServerHostnames, IPAddresses ipAddresses) {
+ public DockerOperationsImpl(Docker docker, ProcessExecuter processExecuter, IPAddresses ipAddresses) {
this.docker = docker;
this.processExecuter = processExecuter;
- this.configServerHostnames = configServerHostnames;
this.ipAddresses = ipAddresses;
}
@@ -66,15 +63,12 @@ public class DockerOperationsImpl implements DockerOperations {
() -> new RuntimeException("Unable to find a valid IPv6 address for " + node.getHostname() +
". Missing an AAAA DNS entry?"));
- String configServers = String.join(",", configServerHostnames);
-
Docker.CreateContainerCommand command = docker.createContainerCommand(
node.getWantedDockerImage().get(),
ContainerResources.from(node.getMinCpuCores(), node.getMinMainMemoryAvailableGb()),
context.containerName(),
node.getHostname())
.withManagedBy(MANAGER_NAME)
- .withEnvironment("VESPA_CONFIGSERVERS", configServers)
.withUlimit("nofile", 262_144, 262_144)
.withUlimit("nproc", 32_768, 409_600)
.withUlimit("core", -1, -1)
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/docker/DockerOperationsImplTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/docker/DockerOperationsImplTest.java
index d93d33617e3..99b3fde4eb1 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/docker/DockerOperationsImplTest.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/docker/DockerOperationsImplTest.java
@@ -20,7 +20,6 @@ import org.mockito.InOrder;
import java.io.IOException;
import java.net.InetAddress;
import java.nio.file.Paths;
-import java.util.Collections;
import java.util.Optional;
import java.util.OptionalLong;
@@ -40,7 +39,7 @@ public class DockerOperationsImplTest {
private final ProcessExecuter processExecuter = mock(ProcessExecuter.class);
private final IPAddresses ipAddresses = new IPAddressesMock();
private final DockerOperationsImpl dockerOperations = new DockerOperationsImpl(
- docker, processExecuter, Collections.emptyList(), ipAddresses);
+ docker, processExecuter, ipAddresses);
@Test
public void processResultFromNodeProgramWhenSuccess() {
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/integrationTests/DockerTester.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/integrationTests/DockerTester.java
index 9385e604142..b9592c9787d 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/integrationTests/DockerTester.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/integrationTests/DockerTester.java
@@ -29,7 +29,6 @@ import java.nio.file.Path;
import java.nio.file.Paths;
import java.time.Clock;
import java.time.Duration;
-import java.util.Collections;
import java.util.Optional;
import java.util.function.Function;
import java.util.logging.Logger;
@@ -90,7 +89,7 @@ public class DockerTester implements AutoCloseable {
Clock clock = Clock.systemUTC();
FileSystem fileSystem = TestFileSystem.create();
- DockerOperations dockerOperations = new DockerOperationsImpl(docker, processExecuter, Collections.emptyList(), ipAddresses);
+ DockerOperations dockerOperations = new DockerOperationsImpl(docker, processExecuter, ipAddresses);
MetricReceiverWrapper mr = new MetricReceiverWrapper(MetricReceiver.nullImplementation);
Function<String, NodeAgent> nodeAgentFactory = (hostName) -> new NodeAgentImpl(