diff options
author | Håkon Hallingstad <hakon@yahooinc.com> | 2023-07-04 17:28:59 +0200 |
---|---|---|
committer | Håkon Hallingstad <hakon@yahooinc.com> | 2023-07-04 17:28:59 +0200 |
commit | 34d88b552e807316581ca546e873bd4ec87bace5 (patch) | |
tree | 5b94b445c5071c55087c2bc81de0ff05fe42c24d /node-repository/src/test | |
parent | bf4e236e3f9722c9b95e4d5fef21b61fc5c9c93a (diff) |
Exclude private IP addresses in other cloud accounts in ACLs
Diffstat (limited to 'node-repository/src/test')
8 files changed, 144 insertions, 165 deletions
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/provisioning/AclProvisioningTest.java b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/provisioning/AclProvisioningTest.java index ab99a44cbab..87b9a85edcd 100644 --- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/provisioning/AclProvisioningTest.java +++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/provisioning/AclProvisioningTest.java @@ -61,7 +61,7 @@ public class AclProvisioningTest { Supplier<NodeAcl> nodeAcls = () -> node.acl(tester.nodeRepository().nodes().list(), tester.nodeRepository().loadBalancers(), tester.nodeRepository().zone()); // Trusted nodes are active nodes in same application, proxy nodes and config servers - assertAcls(trustedNodesOf(List.of(activeNodes, proxyNodes, configServers.asList(), hostOfNode)), + assertAcls(trustedNodesOf(List.of(activeNodes, proxyNodes, configServers.asList(), hostOfNode), node.cloudAccount()), Set.of("10.2.3.0/24", "10.4.5.0/24"), List.of(nodeAcls.get())); } @@ -83,7 +83,7 @@ public class AclProvisioningTest { NodeList tenantNodes = tester.nodeRepository().nodes().list().nodeType(NodeType.tenant); // Trusted nodes are all proxy-, config-, and, tenant-nodes - assertAcls(trustedNodesOf(List.of(proxyNodes, configServers.asList(), tenantNodes.asList())), List.of(nodeAcl)); + assertAcls(trustedNodesOf(List.of(proxyNodes, configServers.asList(), tenantNodes.asList()), node.cloudAccount()), List.of(nodeAcl)); } @Test @@ -108,11 +108,11 @@ public class AclProvisioningTest { NodeAcl nodeAcl = node.acl(nodes, tester.nodeRepository().loadBalancers(), tester.nodeRepository().zone()); // Trusted nodes is all tenant nodes+hosts, all proxy nodes+hosts, all config servers and load balancer subnets - assertAcls(List.of(TrustedNode.of(tenantHosts, Set.of(19070)), - TrustedNode.of(tenantNodes, Set.of(19070)), - TrustedNode.of(proxyHosts, Set.of(19070)), - TrustedNode.of(proxyNodes, Set.of(19070)), - TrustedNode.of(configNodes)), + assertAcls(List.of(TrustedNode.of(tenantHosts, Set.of(19070), node.cloudAccount()), + TrustedNode.of(tenantNodes, Set.of(19070), node.cloudAccount()), + TrustedNode.of(proxyHosts, Set.of(19070), node.cloudAccount()), + TrustedNode.of(proxyNodes, Set.of(19070), node.cloudAccount()), + TrustedNode.of(configNodes, node.cloudAccount())), Set.of("10.2.3.0/24", "10.4.5.0/24"), List.of(nodeAcl)); assertEquals(Set.of(22, 4443), nodeAcl.trustedPorts()); @@ -145,7 +145,7 @@ public class AclProvisioningTest { NodeAcl nodeAcl = node.acl(tester.nodeRepository().nodes().list(), tester.nodeRepository().loadBalancers(), tester.nodeRepository().zone()); // Trusted nodes is all config servers and all proxy nodes - assertAcls(trustedNodesOf(List.of(proxyNodes.asList(), configServers.asList())), List.of(nodeAcl)); + assertAcls(trustedNodesOf(List.of(proxyNodes.asList(), configServers.asList()), node.cloudAccount()), List.of(nodeAcl)); assertEquals(Set.of(22, 443, 4443), nodeAcl.trustedPorts()); assertEquals(Set.of(), nodeAcl.trustedUdpPorts()); } @@ -171,7 +171,7 @@ public class AclProvisioningTest { .findFirst() .orElseThrow(() -> new RuntimeException("Expected to find ACL for node " + node.hostname())); assertEquals(host.hostname(), node.parentHostname().get()); - assertAcls(trustedNodesOf(List.of(configServers.asList(), nodes, List.of(host))), nodeAcl); + assertAcls(trustedNodesOf(List.of(configServers.asList(), nodes, List.of(host)), node.cloudAccount()), nodeAcl); } } @@ -185,7 +185,7 @@ public class AclProvisioningTest { // Controllers and hosts all trust each other NodeAcl controllerAcl = controllers.get(0).acl(tester.nodeRepository().nodes().list(), tester.nodeRepository().loadBalancers(), tester.nodeRepository().zone()); - assertAcls(trustedNodesOf(List.of(controllers)), Set.of("10.2.3.0/24", "10.4.5.0/24"), List.of(controllerAcl)); + assertAcls(trustedNodesOf(List.of(controllers), controllers.get(0).cloudAccount()), Set.of("10.2.3.0/24", "10.4.5.0/24"), List.of(controllerAcl)); assertEquals(Set.of(22, 4443, 443), controllerAcl.trustedPorts()); assertEquals(Set.of(), controllerAcl.trustedUdpPorts()); } @@ -238,12 +238,12 @@ public class AclProvisioningTest { nodeAcl.trustedNodes().stream().map(TrustedNode::ipAddresses).toList()); } - private static List<List<TrustedNode>> trustedNodesOf(List<List<Node>> nodes, Set<Integer> ports) { - return nodes.stream().map(node -> TrustedNode.of(node, ports)).toList(); + private static List<List<TrustedNode>> trustedNodesOf(List<List<Node>> nodes, Set<Integer> ports, CloudAccount cloudAccount) { + return nodes.stream().map(node -> TrustedNode.of(node, ports, cloudAccount)).toList(); } - private static List<List<TrustedNode>> trustedNodesOf(List<List<Node>> nodes) { - return trustedNodesOf(nodes, Set.of()); + private static List<List<TrustedNode>> trustedNodesOf(List<List<Node>> nodes, CloudAccount cloudAccount) { + return trustedNodesOf(nodes, Set.of(), cloudAccount); } private List<Node> deploy(int nodeCount) { diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiTest.java b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiTest.java index 0ef80cbe6f5..d93c8e3cbeb 100644 --- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiTest.java +++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiTest.java @@ -459,7 +459,7 @@ public class NodesV2ApiTest { } @Test - public void acl_request_by_tenant_node() throws Exception { + public void acls_for_exclave_tenant_host() throws Exception { assertFile(new Request("http://localhost:8080/nodes/v2/acl/host3.yahoo.com"), "acl-tenant-node.json"); } diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/acl-config-server.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/acl-config-server.json index 1800dcacc3d..c5094e03348 100644 --- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/acl-config-server.json +++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/acl-config-server.json @@ -3,256 +3,304 @@ { "hostname": "cfg1.yahoo.com", "type": "config", - "ipAddress": "127.0.201.1", + "ipAddress": "::201:1", "trustedBy": "cfg1.yahoo.com" }, { "hostname": "cfg1.yahoo.com", "type": "config", - "ipAddress": "::201:1", + "ipAddress": "127.0.201.1", "trustedBy": "cfg1.yahoo.com" }, { "hostname": "cfg2.yahoo.com", "type": "config", - "ipAddress": "127.0.202.1", + "ipAddress": "::202:1", "trustedBy": "cfg1.yahoo.com" }, { "hostname": "cfg2.yahoo.com", "type": "config", - "ipAddress": "::202:1", - "trustedBy": "cfg1.yahoo.com" - }, - { - "hostname": "dockerhost1.yahoo.com", - "type": "host", - "ipAddress": "127.0.100.1", - "ports": [19070], + "ipAddress": "127.0.202.1", "trustedBy": "cfg1.yahoo.com" }, { "hostname": "dockerhost1.yahoo.com", "type": "host", "ipAddress": "::100:1", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { - "hostname": "dockerhost2.yahoo.com", + "hostname": "dockerhost1.yahoo.com", "type": "host", - "ipAddress": "127.0.101.1", - "ports": [19070], + "ipAddress": "127.0.100.1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "dockerhost2.yahoo.com", "type": "host", "ipAddress": "::101:1", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "dockerhost3.yahoo.com", "type": "host", - "ipAddress": "127.0.102.1", - "ports": [19070], + "ipAddress": "::102:1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "dockerhost3.yahoo.com", "type": "host", - "ipAddress": "::102:1", - "ports": [19070], + "ipAddress": "127.0.102.1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "dockerhost4.yahoo.com", "type": "host", - "ipAddress": "127.0.103.1", - "ports": [19070], + "ipAddress": "::103:1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "dockerhost4.yahoo.com", "type": "host", - "ipAddress": "::103:1", - "ports": [19070], + "ipAddress": "127.0.103.1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "dockerhost5.yahoo.com", "type": "host", - "ipAddress": "127.0.104.1", - "ports": [19070], + "ipAddress": "::104:1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "dockerhost5.yahoo.com", "type": "host", - "ipAddress": "::104:1", - "ports": [19070], + "ipAddress": "127.0.104.1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host1.yahoo.com", "type": "tenant", - "ipAddress": "127.0.1.1", - "ports": [19070], + "ipAddress": "::1:1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host1.yahoo.com", "type": "tenant", - "ipAddress": "::1:1", - "ports": [19070], + "ipAddress": "127.0.1.1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host10.yahoo.com", "type": "tenant", - "ipAddress": "127.0.10.1", - "ports": [19070], + "ipAddress": "::10:1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host10.yahoo.com", "type": "tenant", - "ipAddress": "::10:1", - "ports": [19070], + "ipAddress": "127.0.10.1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host13.yahoo.com", "type": "tenant", "ipAddress": "127.0.13.1", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host13.yahoo.com", "type": "tenant", "ipAddress": "::13:1", - "ports": [19070], - "trustedBy": "cfg1.yahoo.com" - }, - { - "hostname": "host14.yahoo.com", - "type": "tenant", - "ipAddress": "127.0.14.1", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host14.yahoo.com", "type": "tenant", "ipAddress": "::14:1", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { - "hostname": "host2.yahoo.com", + "hostname": "host14.yahoo.com", "type": "tenant", - "ipAddress": "127.0.2.1", - "ports": [19070], + "ipAddress": "127.0.14.1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host2.yahoo.com", "type": "tenant", "ipAddress": "::2:1", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { - "hostname": "host3.yahoo.com", + "hostname": "host2.yahoo.com", "type": "tenant", - "ipAddress": "127.0.3.1", - "ports": [19070], + "ipAddress": "127.0.2.1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host3.yahoo.com", "type": "tenant", "ipAddress": "::3:1", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host4.yahoo.com", "type": "tenant", "ipAddress": "127.0.4.1", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host4.yahoo.com", "type": "tenant", "ipAddress": "::4:1", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host5.yahoo.com", "type": "tenant", - "ipAddress": "127.0.5.1", - "ports": [19070], + "ipAddress": "::5:1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host5.yahoo.com", "type": "tenant", - "ipAddress": "::5:1", - "ports": [19070], + "ipAddress": "127.0.5.1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host55.yahoo.com", "type": "tenant", - "ipAddress": "127.0.55.1", - "ports": [19070], + "ipAddress": "::55:1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host55.yahoo.com", "type": "tenant", - "ipAddress": "::55:1", - "ports": [19070], + "ipAddress": "127.0.55.1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host6.yahoo.com", "type": "tenant", "ipAddress": "127.0.6.1", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host6.yahoo.com", "type": "tenant", "ipAddress": "::6:1", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host7.yahoo.com", "type": "tenant", - "ipAddress": "127.0.7.1", - "ports": [19070], + "ipAddress": "::7:1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "host7.yahoo.com", "type": "tenant", - "ipAddress": "::7:1", - "ports": [19070], + "ipAddress": "127.0.7.1", + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" }, { "hostname": "test-node-pool-102-2", "type": "tenant", "ipAddress": "::102:2", - "ports": [19070], + "ports": [ + 19070 + ], "trustedBy": "cfg1.yahoo.com" } ], @@ -268,14 +316,13 @@ ], "trustedPorts": [ { - "port":22, - "trustedBy":"cfg1.yahoo.com" + "port": 22, + "trustedBy": "cfg1.yahoo.com" }, { "port": 4443, "trustedBy": "cfg1.yahoo.com" } ], - "trustedUdpPorts": [ - ] + "trustedUdpPorts": [] } diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/acl-tenant-node.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/acl-tenant-node.json index bdc0dc21c95..f947540f7c5 100644 --- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/acl-tenant-node.json +++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/acl-tenant-node.json @@ -3,84 +3,42 @@ { "hostname": "cfg1.yahoo.com", "type": "config", - "ipAddress": "127.0.201.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "cfg1.yahoo.com", - "type": "config", "ipAddress": "::201:1", "trustedBy": "host3.yahoo.com" }, { "hostname": "cfg2.yahoo.com", "type": "config", - "ipAddress": "127.0.202.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "cfg2.yahoo.com", - "type": "config", "ipAddress": "::202:1", "trustedBy": "host3.yahoo.com" }, { "hostname": "host1.yahoo.com", "type": "tenant", - "ipAddress": "127.0.1.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "host1.yahoo.com", - "type": "tenant", "ipAddress": "::1:1", "trustedBy": "host3.yahoo.com" }, { "hostname": "host10.yahoo.com", "type": "tenant", - "ipAddress": "127.0.10.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "host10.yahoo.com", - "type": "tenant", "ipAddress": "::10:1", "trustedBy": "host3.yahoo.com" }, { "hostname": "host13.yahoo.com", "type": "tenant", - "ipAddress": "127.0.13.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "host13.yahoo.com", - "type": "tenant", "ipAddress": "::13:1", "trustedBy": "host3.yahoo.com" }, { "hostname": "host14.yahoo.com", "type": "tenant", - "ipAddress": "127.0.14.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "host14.yahoo.com", - "type": "tenant", "ipAddress": "::14:1", "trustedBy": "host3.yahoo.com" }, { "hostname": "host2.yahoo.com", "type": "tenant", - "ipAddress": "127.0.2.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "host2.yahoo.com", - "type": "tenant", "ipAddress": "::2:1", "trustedBy": "host3.yahoo.com" }, @@ -99,60 +57,30 @@ { "hostname": "host4.yahoo.com", "type": "tenant", - "ipAddress": "127.0.4.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "host4.yahoo.com", - "type": "tenant", "ipAddress": "::4:1", "trustedBy": "host3.yahoo.com" }, { "hostname": "host5.yahoo.com", "type": "tenant", - "ipAddress": "127.0.5.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "host5.yahoo.com", - "type": "tenant", "ipAddress": "::5:1", "trustedBy": "host3.yahoo.com" }, { "hostname": "host55.yahoo.com", "type": "tenant", - "ipAddress": "127.0.55.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "host55.yahoo.com", - "type": "tenant", "ipAddress": "::55:1", "trustedBy": "host3.yahoo.com" }, { "hostname": "host6.yahoo.com", "type": "tenant", - "ipAddress": "127.0.6.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "host6.yahoo.com", - "type": "tenant", "ipAddress": "::6:1", "trustedBy": "host3.yahoo.com" }, { "hostname": "host7.yahoo.com", "type": "tenant", - "ipAddress": "127.0.7.1", - "trustedBy": "host3.yahoo.com" - }, - { - "hostname": "host7.yahoo.com", - "type": "tenant", "ipAddress": "::7:1", "trustedBy": "host3.yahoo.com" }, diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg1.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg1.json index 60c19ec040b..52da67da9bf 100644 --- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg1.json +++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg1.json @@ -117,5 +117,6 @@ "::201:1" ], "additionalIpAddresses": [], + "cloudAccount": "aws:111222333444", "wireguardPubkey":"lololololololololololololololololololololoo=" } diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg2.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg2.json index 3bd45acb856..bc1d04546e6 100644 --- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg2.json +++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/cfg2.json @@ -116,5 +116,6 @@ "127.0.202.1", "::202:1" ], - "additionalIpAddresses": [] + "additionalIpAddresses": [], + "cloudAccount": "aws:111222333444" } diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node13.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node13.json index f5152efd7cb..d0907ac5163 100644 --- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node13.json +++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node13.json @@ -76,5 +76,6 @@ "127.0.13.1", "::13:1" ], - "additionalIpAddresses": [] + "additionalIpAddresses": [], + "cloudAccount": "aws:111222333444" } diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node14.json b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node14.json index f48e52b18bf..c80656800f0 100644 --- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node14.json +++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/responses/node14.json @@ -76,5 +76,6 @@ "127.0.14.1", "::14:1" ], - "additionalIpAddresses": [] + "additionalIpAddresses": [], + "cloudAccount": "aws:111222333444" } |