summaryrefslogtreecommitdiffstats
path: root/node-repository/src
diff options
context:
space:
mode:
authorHarald Musum <musum@verizonmedia.com>2021-03-23 10:57:08 +0100
committerHarald Musum <musum@verizonmedia.com>2021-03-23 11:00:01 +0100
commit18f0597aa95cc9a6cd723a7c53abcb2438bc38d5 (patch)
tree1befa17a07466fb1f67c3e9bf827be82afc7a14f /node-repository/src
parentc0fad9ba326814d396916d86552abee573e7903d (diff)
Increase inactive expiry time for none-prod and cd zones
To avoid issues with nodes being deallocated in node repo, but all config servers not having completed cleanup after removal of application wait a bit longer before expiring inactive nodes
Diffstat (limited to 'node-repository/src')
-rw-r--r--node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeRepositoryMaintenance.java6
1 files changed, 4 insertions, 2 deletions
diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeRepositoryMaintenance.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeRepositoryMaintenance.java
index 98f28da8c82..46230ed38a4 100644
--- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeRepositoryMaintenance.java
+++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/NodeRepositoryMaintenance.java
@@ -150,12 +150,14 @@ public class NodeRepositoryMaintenance extends AbstractComponent {
inactiveConfigServerExpiry = Duration.ofMinutes(5);
inactiveControllerExpiry = Duration.ofMinutes(5);
- if (zone.environment() == Environment.prod && ! zone.system().isCd()) {
+ if (zone.environment().isProduction() && ! zone.system().isCd()) {
inactiveExpiry = Duration.ofHours(4); // enough time for the application owner to discover and redeploy
retiredInterval = Duration.ofMinutes(30);
dirtyExpiry = Duration.ofHours(2); // enough time to clean the node
} else {
- inactiveExpiry = Duration.ofSeconds(2); // support interactive wipe start over
+ // long enough that nodes aren't reused immediately and delete can happen on all config servers
+ // with time enough to clean up even with ZK connection issues on config servers
+ inactiveExpiry = Duration.ofMinutes(1);
retiredInterval = Duration.ofMinutes(1);
dirtyExpiry = Duration.ofMinutes(30);
}