Require OS version to be non-empty

1 files changed, 7 insertions, 1 deletions

diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/os/OsVersion.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/os/OsVersion.java
index 99945ce46e8..8719a80e578 100644
--- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/os/OsVersion.java
+++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/os/OsVersion.java
@@ -16,7 +16,7 @@ public class OsVersion {
     private final boolean active;
 
     public OsVersion(Version version, boolean active) {
-        this.version = version;
+        this.version = requireNonEmpty(version);
         this.active = active;
     }
 
@@ -49,4 +49,10 @@ public class OsVersion {
         return "OS version " + version + " [active: " + active + "]";
     }
 
+    private static Version requireNonEmpty(Version version) {
+        Objects.requireNonNull(version, "version must be non-null");
+        if (version.isEmpty()) throw new IllegalArgumentException("version must be non-empty");
+        return version;
+    }
+
 }