diff options
author | Martin Polden <mpolden@mpolden.no> | 2018-03-06 12:23:26 +0100 |
---|---|---|
committer | Martin Polden <mpolden@mpolden.no> | 2018-03-06 12:31:20 +0100 |
commit | 976c7b88052cb1142ca5c8a1cebdf498f4fb4b95 (patch) | |
tree | 27ee035b5c875f207b52cba31e43867398ae3cdb /node-repository | |
parent | 9258dde254882c6e21ea93b282098729cc68c6cf (diff) |
Simplify testing of responses with ignored fields
Diffstat (limited to 'node-repository')
-rw-r--r-- | node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/v2/RestApiTest.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/v2/RestApiTest.java b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/v2/RestApiTest.java index 0e9e3464c02..9a0856f5afa 100644 --- a/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/v2/RestApiTest.java +++ b/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/restapi/v2/RestApiTest.java @@ -583,11 +583,13 @@ public class RestApiTest { private void assertFile(Request request, String responseFile) throws IOException { String expectedResponse = IOUtils.readFile(new File(responsesPath + responseFile)); expectedResponse = include(expectedResponse); - expectedResponse = expectedResponse.replaceAll("\\s", ""); + expectedResponse = expectedResponse.replaceAll("(\"[^\"]*\")|\\s*", "$1"); // Remove whitespace String responseString = container.handleRequest(request).getBodyAsString(); if (expectedResponse.contains("(ignore)")) { + // Convert expected response to a literal pattern and replace any ignored field with a pattern that matches + // anything String expectedResponsePattern = Pattern.quote(expectedResponse) - .replaceAll("\\(ignore\\)", "\\\\E.*\\\\Q"); + .replaceAll("\"?\\(ignore\\)\"?", "\\\\E.*\\\\Q"); if (!Pattern.matches(expectedResponsePattern, responseString)) { throw new ComparisonFailure(responseFile + " (with ignored fields)", expectedResponsePattern, responseString); |