diff options
| author | Martin Polden <martin.polden@gmail.com> | 2017-04-04 12:45:28 +0200 |
|---|---|---|
| committer | Martin Polden <martin.polden@gmail.com> | 2017-04-04 13:02:47 +0200 |
| commit | d97e16bd6997b835139491de439cf2396a7fa651 (patch) | |
| tree | 81bd2b01c7db3ba0171117871cb59906f0ae0a08 /node-repository | |
| parent | 2132e0bf56e09016f6e2ae020ab42352e56072cc (diff) | |
Fix TODO
Diffstat (limited to 'node-repository')
3 files changed, 1 insertions, 7 deletions
diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/node/Status.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/node/Status.java index 1d8a1356836..7946b093b10 100644 --- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/node/Status.java +++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/node/Status.java @@ -30,10 +30,7 @@ public class Status { /** There are smart log error messages */ disk_smart, /** There are kernel log error messages */ - disk_kernel, - /** There is an error but its type is unknown */ - // TODO: Remove this when all hosts in the node repo has a failure type - unknown + disk_kernel } diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/NodeSerializer.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/NodeSerializer.java index 5e9d1ddd6a1..7f13ff1a13c 100644 --- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/NodeSerializer.java +++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/NodeSerializer.java @@ -325,7 +325,6 @@ public class NodeSerializer { case "memory_mcelog" : return Status.HardwareFailureType.memory_mcelog; case "disk_smart" : return Status.HardwareFailureType.disk_smart; case "disk_kernel" : return Status.HardwareFailureType.disk_kernel; - case "unknown" : return Status.HardwareFailureType.unknown; default : throw new IllegalArgumentException("Unknown hardware failure '" + hardwareFailureString + "'"); } } @@ -334,7 +333,6 @@ public class NodeSerializer { case memory_mcelog: return "memory_mcelog"; case disk_smart: return "disk_smart"; case disk_kernel: return "disk_kernel"; - case unknown: return "unknown"; default : throw new IllegalArgumentException("Serialized form of '" + type + " not defined"); } } diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/v2/NodesResponse.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/v2/NodesResponse.java index 5822175572f..2766a219931 100644 --- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/v2/NodesResponse.java +++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/v2/NodesResponse.java @@ -230,7 +230,6 @@ class NodesResponse extends HttpResponse { case memory_mcelog: return "memory_mcelog"; case disk_smart: return "disk_smart"; case disk_kernel: return "disk_kernel"; - case unknown: return "unknown"; default : throw new IllegalArgumentException("Serialized form of '" + type + " not defined"); } } |