Throw IllegalStateException instead of returning null.

1 files changed, 6 insertions, 1 deletions

diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/CuratorDatabase.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/CuratorDatabase.java
index d583cd349b5..203f52a7b70 100644
--- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/CuratorDatabase.java
+++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/CuratorDatabase.java
@@ -106,7 +106,12 @@ public class CuratorDatabase {
             return generation != cache.generation();
         }
         public CuratorDatabaseCache validCache() {
-            return !expired() ? cache : null;
+            if (expired()) {
+                throw new IllegalStateException("The cache has generation " + cache.generation() +
+                        " while the root genration counter in zookeeper says " + generation +
+                        ". That is totally unacceptable and must be a sever programming error in my close vicinity.");
+            }
+            return cache;
         }
 
         private CuratorDatabaseCache cache;