diff options
author | Harald Musum <musum@oath.com> | 2018-07-18 10:56:31 +0200 |
---|---|---|
committer | Harald Musum <musum@oath.com> | 2018-07-18 10:56:31 +0200 |
commit | d4c7c4e49f5696a70fcc14eeba10174ac8abf826 (patch) | |
tree | aa6d43987e995738e486dcc74812e21aaca8b50a /node-repository | |
parent | 02cd0ad0e25ababf9a26bfdccf42ff51b649e0f7 (diff) |
Add some logging
Diffstat (limited to 'node-repository')
2 files changed, 9 insertions, 5 deletions
diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ApplicationMaintainer.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ApplicationMaintainer.java index b9dff572d5b..afc6a69796d 100644 --- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ApplicationMaintainer.java +++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ApplicationMaintainer.java @@ -5,6 +5,7 @@ import com.yahoo.concurrent.DaemonThreadFactory; import com.yahoo.config.provision.ApplicationId; import com.yahoo.config.provision.Deployer; import com.yahoo.config.provision.Deployment; +import com.yahoo.log.LogLevel; import com.yahoo.transaction.Mutex; import com.yahoo.vespa.hosted.provision.Node; import com.yahoo.vespa.hosted.provision.NodeRepository; @@ -16,7 +17,6 @@ import java.util.Optional; import java.util.Set; import java.util.concurrent.Executor; import java.util.concurrent.Executors; -import java.util.logging.Level; import java.util.stream.Collectors; /** @@ -77,7 +77,7 @@ public abstract class ApplicationMaintainer extends Maintainer { /** Redeploy this application. A lock will be taken for the duration of the deployment activation */ final void deployWithLock(ApplicationId application) { - // An application might change it's state between the time the set of applications is retrieved and the + // An application might change its state between the time the set of applications is retrieved and the // time deployment happens. Lock the application and check if it's still active. // // Lock is acquired with a low timeout to reduce the chance of colliding with an external deployment. @@ -85,9 +85,10 @@ public abstract class ApplicationMaintainer extends Maintainer { if ( ! isActive(application)) return; // became inactive since deployment was requested Optional<Deployment> deployment = deployer.deployFromLocalActive(application); if ( ! deployment.isPresent()) return; // this will be done at another config server + log.log(LogLevel.DEBUG, this.getClass().getSimpleName() + " deploying " + application); deployment.get().activate(); } catch (RuntimeException e) { - log.log(Level.WARNING, "Exception on maintenance redeploy", e); + log.log(LogLevel.WARNING, "Exception on maintenance redeploy", e); } } diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/PeriodicApplicationMaintainer.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/PeriodicApplicationMaintainer.java index 2ce5046edbf..953c56e8411 100644 --- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/PeriodicApplicationMaintainer.java +++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/PeriodicApplicationMaintainer.java @@ -3,6 +3,7 @@ package com.yahoo.vespa.hosted.provision.maintenance; import com.yahoo.config.provision.ApplicationId; import com.yahoo.config.provision.Deployer; +import com.yahoo.log.LogLevel; import com.yahoo.vespa.hosted.provision.Node; import com.yahoo.vespa.hosted.provision.NodeRepository; @@ -40,10 +41,12 @@ public class PeriodicApplicationMaintainer extends ApplicationMaintainer { // Returns the app that was deployed the longest time ago @Override protected Set<ApplicationId> applicationsNeedingMaintenance() { - Optional<ApplicationId> apps = (nodesNeedingMaintenance().stream() + Optional<ApplicationId> app = (nodesNeedingMaintenance().stream() .map(node -> node.allocation().get().owner()) .min(Comparator.comparing(this::getLastDeployTime))); - return apps.map(applicationId -> new HashSet<>(Collections.singletonList(applicationId))).orElseGet(HashSet::new); + app.ifPresent(applicationId -> log.log(LogLevel.INFO, applicationId + " will be deployed, last deploy time " + + getLastDeployTime(applicationId))); + return app.map(applicationId -> new HashSet<>(Collections.singletonList(applicationId))).orElseGet(HashSet::new); } private Instant getLastDeployTime(ApplicationId application) { |