diff options
author | toby <smorgrav@yahoo-inc.com> | 2017-08-16 11:37:34 +0200 |
---|---|---|
committer | toby <smorgrav@yahoo-inc.com> | 2017-08-16 11:37:34 +0200 |
commit | cdcedfd455de6d27ea4fdf41a99184d127fb8f85 (patch) | |
tree | d62a2686064e039f743937f313c80441a205557b /node-repository | |
parent | f317755d70b6613ab75b8a03030e13f0f1d07b9d (diff) |
Update unit tests in node-admin according to changes in node-repository
Diffstat (limited to 'node-repository')
-rw-r--r-- | node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/v2/NodesApiHandler.java | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/v2/NodesApiHandler.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/v2/NodesApiHandler.java index 6d6f52aa831..594983be698 100644 --- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/v2/NodesApiHandler.java +++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/v2/NodesApiHandler.java @@ -128,15 +128,17 @@ public class NodesApiHandler extends LoggingRequestHandler { /** * This is a temporary "state" or rest call that we use to enable a smooth rollout of * dynamic docker flavor allocations. Once we have switch everything we remove this - * and change the code in the nodeadmin to delete directly. + * and change the code in the nodeadmin to delete directly (remember to allow deletion of dirty nodes then). * * Should only be called by node-admin for docker containers (the docker constraint is * enforced in the remove method) */ String hostname = lastElement(path); if (nodeRepository.dynamicAllocationEnabled()) { - nodeRepository.remove(hostname); - return new MessageResponse("Removed " + hostname); + if (nodeRepository.remove(hostname)) + return new MessageResponse("Removed " + hostname); + else + throw new NotFoundException("No node in the provisioned, parked, dirty or failed state with hostname " + hostname); } else { nodeRepository.setReady(hostname); return new MessageResponse("Moved " + hostname + " to ready"); |