summaryrefslogtreecommitdiffstats
path: root/node-repository
diff options
context:
space:
mode:
authorValerij Fredriksen <valerijf@oath.com>2018-07-26 11:50:10 +0200
committerValerij Fredriksen <valerijf@oath.com>2018-07-26 11:50:10 +0200
commit5602d9cc9eeb85f2997db079f8d9a4f27098ec13 (patch)
tree29551c4e21b7c27385a0265b3fda20bb52ea87ee /node-repository
parente854864520d3734ed1baced433b9883f61964cc3 (diff)
Use immutable collections instead
Diffstat (limited to 'node-repository')
-rw-r--r--node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/PeriodicApplicationMaintainer.java5
1 files changed, 2 insertions, 3 deletions
diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/PeriodicApplicationMaintainer.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/PeriodicApplicationMaintainer.java
index dba50bc760b..6d024a421a2 100644
--- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/PeriodicApplicationMaintainer.java
+++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/PeriodicApplicationMaintainer.java
@@ -11,7 +11,6 @@ import java.time.Duration;
import java.time.Instant;
import java.util.Collections;
import java.util.Comparator;
-import java.util.HashSet;
import java.util.List;
import java.util.Optional;
import java.util.Set;
@@ -43,7 +42,7 @@ public class PeriodicApplicationMaintainer extends ApplicationMaintainer {
// Returns the app that was deployed the longest time ago
@Override
protected Set<ApplicationId> applicationsNeedingMaintenance() {
- if (waitInitially()) return new HashSet<>();
+ if (waitInitially()) return Collections.emptySet();
Optional<ApplicationId> app = (nodesNeedingMaintenance().stream()
.map(node -> node.allocation().get().owner())
@@ -51,7 +50,7 @@ public class PeriodicApplicationMaintainer extends ApplicationMaintainer {
.min(Comparator.comparing(this::getLastDeployTime)));
app.ifPresent(applicationId -> log.log(LogLevel.INFO, applicationId + " will be deployed, last deploy time " +
getLastDeployTime(applicationId)));
- return app.map(applicationId -> new HashSet<>(Collections.singletonList(applicationId))).orElseGet(HashSet::new);
+ return app.map(Collections::singleton).orElseGet(Collections::emptySet);
}
private Instant getLastDeployTime(ApplicationId application) {