Merge pull request #11824 from vespa-engine/freva/do-not-count-retired

Only consider non-retired node when determining number of groups/cluster size

1 files changed, 3 insertions, 2 deletions

diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/provisioning/NodePrioritizer.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/provisioning/NodePrioritizer.java
index b8d7ff04efa..a17d92117fb 100644
--- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/provisioning/NodePrioritizer.java
+++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/provisioning/NodePrioritizer.java
@@ -63,7 +63,8 @@ public class NodePrioritizer {
         this.inPlaceResizeEnabled = inPlaceResizeEnabled;
 
         NodeList nodesInCluster = allNodes.owner(appId).type(clusterSpec.type()).cluster(clusterSpec.id());
-        long currentGroups = nodesInCluster.state(Node.State.active).stream()
+        NodeList nonRetiredNodesInCluster = nodesInCluster.not().retired();
+        long currentGroups = nonRetiredNodesInCluster.state(Node.State.active).stream()
                 .flatMap(node -> node.allocation()
                         .flatMap(alloc -> alloc.membership().cluster().group().map(ClusterSpec.Group::index))
                         .stream())
@@ -71,7 +72,7 @@ public class NodePrioritizer {
                 .count();
         this.isTopologyChange = currentGroups != wantedGroups;
 
-        this.currentClusterSize = (int) nodesInCluster.state(Node.State.active).stream()
+        this.currentClusterSize = (int) nonRetiredNodesInCluster.state(Node.State.active).stream()
                 .map(node -> node.allocation().flatMap(alloc -> alloc.membership().cluster().group()))
                 .filter(clusterSpec.group()::equals)
                 .count();