summaryrefslogtreecommitdiffstats
path: root/node-repository
diff options
context:
space:
mode:
authorJon Bratseth <bratseth@verizonmedia.com>2019-06-15 19:20:52 +0200
committerJon Bratseth <bratseth@verizonmedia.com>2019-06-15 19:20:52 +0200
commit0de2f80d8931e59b88c0add703a71bd204e0a619 (patch)
tree69e8c4342be1a7e6f6baca526f906f0451af3b77 /node-repository
parent1b2c6aa193483f9a7eaaf17a5a82037b93bd1749 (diff)
Add a comment warning about serialization format changes
Diffstat (limited to 'node-repository')
-rw-r--r--node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/NodeSerializer.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/NodeSerializer.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/NodeSerializer.java
index d38a6e5031c..424889caf72 100644
--- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/NodeSerializer.java
+++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/persistence/NodeSerializer.java
@@ -44,12 +44,12 @@ import java.util.function.UnaryOperator;
*/
public class NodeSerializer {
- // WARNING: Since there are multiple config servers in a cluster and they upgrade one by one
- // (and rewrite all nodes on startup),
- // changes to the serialized format must be made such that what is serialized on version N+1
- // can be read by version N:
+ // WARNING: Since there are multiple servers in a ZooKeeper cluster and they upgrade one by one
+ // (and rewrite all nodes on startup), changes to the serialized format must be made
+ // such that what is serialized on version N+1 can be read by version N:
// - ADDING FIELDS: Always ok
// - REMOVING FIELDS: Stop reading the field first. Stop writing it on a later version.
+ // - CHANGING THE FORMAT OF A FIELD: Don't do it bro.
/** The configured node flavors */
private final NodeFlavors flavors;