add -Werror as default compiler option

lint warnings considered less useful are disabled by default:

* "lint:serial" warns whenever you extend a serializable
  class, even for anonymous classes.  We don't use java
  serialization anyway so turn this off.
* "lint:try" warns when you want to do setup-teardown
  style using an AutoClosable, there's no good reason
  that I can see why this should produce a warning.
* "lint:processing" warns when annotations aren't
  "claimed", but we don't have control over the
  various annotation processors used, so we can't fix
  these warnings.
* "lint:varargs" gives totally bogus warnings, possibly
  because the entire varargs mechanism is badly designed.
  It triggers for any varargs method using Arrays.asList()
  on its arguments, which most of the convenience methods
  really should do.

1 files changed, 5 insertions, 0 deletions

diff --git a/pom.xml b/pom.xml
index 89ca2538545..2b940552fab 100644
--- a/pom.xml
+++ b/pom.xml
@@ -100,6 +100,11 @@
                         <showDeprecation>false</showDeprecation>
 	                <compilerArgs>
 	                    <arg>-Xlint:all</arg>
+	                    <arg>-Xlint:-serial</arg>
+	                    <arg>-Xlint:-try</arg>
+	                    <arg>-Xlint:-processing</arg>
+	                    <arg>-Xlint:-varargs</arg>
+	                    <arg>-Werror</arg>
 	                </compilerArgs>
                     </configuration>
                 </plugin>