Flush attribute to memory first if attribute saver has a

read guard and we are using a spinning disk.  This reduces
the time the read guard is held (and corresponding extra
long term memory usage due to large hold lists) at the cost
of a temporary memory usage spike while flushing attribute.

1 files changed, 4 insertions, 1 deletions

diff --git a/searchcore/src/tests/proton/attribute/attribute_populator/attribute_populator_test.cpp b/searchcore/src/tests/proton/attribute/attribute_populator/attribute_populator_test.cpp
index 36e50249b89..1f69d9136cf 100644
--- a/searchcore/src/tests/proton/attribute/attribute_populator/attribute_populator_test.cpp
+++ b/searchcore/src/tests/proton/attribute/attribute_populator/attribute_populator_test.cpp
@@ -11,6 +11,7 @@ LOG_SETUP("attribute_populator_test");
 #include <vespa/searchlib/index/docbuilder.h>
 #include <vespa/searchlib/index/dummyfileheadercontext.h>
 #include <vespa/vespalib/util/stringfmt.h>
+#include <vespa/vespalib/util/mock_hw_info.h>
 #include <vespa/searchlib/common/foregroundtaskexecutor.h>
 
 using namespace document;
@@ -55,6 +56,7 @@ struct Fixture
     test::DirectoryHandler _testDir;
     DummyFileHeaderContext _fileHeader;
     ForegroundTaskExecutor _attributeFieldWriter;
+    std::shared_ptr<vespalib::IHwInfo> _hwInfo;
     AttributeManager::SP _mgr;
     AttributePopulator _pop;
     DocContext _ctx;
@@ -62,9 +64,10 @@ struct Fixture
         : _testDir(TEST_DIR),
           _fileHeader(),
           _attributeFieldWriter(),
+          _hwInfo(std::make_shared<vespalib::MockHwInfo>()),
           _mgr(new AttributeManager(TEST_DIR, "test.subdb",
                   TuneFileAttributes(),
-                                    _fileHeader, _attributeFieldWriter)),
+                                    _fileHeader, _attributeFieldWriter, _hwInfo)),
           _pop(_mgr, 1, "test"),
           _ctx()
     {