diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2021-05-12 22:27:36 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-05-12 22:27:36 +0200 |
commit | d3062ffb8f2be5538997d3352121129eef454221 (patch) | |
tree | c95e1b75a7a6c5e3f4c505e289123c0278a9bbe1 /searchcore/src/tests/proton/document_iterator | |
parent | 31a5e23e926d87c963295f47e2899679ed02d692 (diff) |
Revert "Revert "Now that everything is controlled bucketwise by the bucket db we shou…""
Diffstat (limited to 'searchcore/src/tests/proton/document_iterator')
-rw-r--r-- | searchcore/src/tests/proton/document_iterator/document_iterator_test.cpp | 56 |
1 files changed, 0 insertions, 56 deletions
diff --git a/searchcore/src/tests/proton/document_iterator/document_iterator_test.cpp b/searchcore/src/tests/proton/document_iterator/document_iterator_test.cpp index 7ee811e66bf..93ad4cc8324 100644 --- a/searchcore/src/tests/proton/document_iterator/document_iterator_test.cpp +++ b/searchcore/src/tests/proton/document_iterator/document_iterator_test.cpp @@ -488,62 +488,6 @@ TEST("require that iterator ignoring maxbytes stops at the end, and does not aut TEST_DO(verifyIterateIgnoringStopSignal(itr)); } -void verifyReadConsistency(DocumentIterator & itr, ILidCommitState & lidCommitState) { - IDocumentRetriever::SP retriever = doc("id:ns:document::1", Timestamp(2), bucket(5)); - auto commitAndWaitRetriever = std::make_shared<CommitAndWaitDocumentRetriever>(retriever, lidCommitState); - itr.add(commitAndWaitRetriever); - - IterateResult res = itr.iterate(largeNum); - EXPECT_TRUE(res.isCompleted()); - EXPECT_EQUAL(1u, res.getEntries().size()); - TEST_DO(checkEntry(res, 0, Document(*DataType::DOCUMENT, DocumentId("id:ns:document::1")), Timestamp(2))); -} - -class ILidCommitStateProxy : public ILidCommitState { -public: - explicit ILidCommitStateProxy(ILidCommitState & lidState) - : _waitCompleteCount(0), - _lidState(lidState) - {} -private: - State waitState(State state, uint32_t lid) const override { - assert(state == State::COMPLETED); - _lidState.waitComplete(lid); - _waitCompleteCount++; - return state; - } - - State waitState(State state, const LidList &lids) const override { - assert(state == State::COMPLETED); - _lidState.waitComplete(lids); - _waitCompleteCount++; - return state; - } - -public: - mutable size_t _waitCompleteCount; -private: - ILidCommitState & _lidState; -}; - -void verifyStrongReadConsistency(DocumentIterator & itr) { - PendingLidTracker lidTracker; - - ILidCommitStateProxy lidCommitState(lidTracker); - TEST_DO(verifyReadConsistency(itr, lidCommitState)); - EXPECT_EQUAL(1u, lidCommitState._waitCompleteCount); -} - -TEST("require that default readconsistency does commit") { - DocumentIterator itr(bucket(5), std::make_shared<document::AllFields>(), selectAll(), newestV(), -1, false); - TEST_DO(verifyStrongReadConsistency(itr)); -} - -TEST("require that readconsistency::strong does commit") { - DocumentIterator itr(bucket(5), std::make_shared<document::AllFields>(), selectAll(), newestV(), -1, false, storage::spi::ReadConsistency::STRONG); - TEST_DO(verifyStrongReadConsistency(itr)); -} - TEST("require that docid limit is honoured") { IDocumentRetriever::SP retriever = doc("id:ns:document::1", Timestamp(2), bucket(5)); auto & udr = dynamic_cast<UnitDR &>(*retriever); |