aboutsummaryrefslogtreecommitdiffstats
path: root/searchcore
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2023-10-30 11:06:28 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2023-10-30 11:06:28 +0000
commitc12c0901cbcadf2cfb37d727076813c9827f2372 (patch)
tree8712db2f50e1051a7b44831295301b586b6a2112 /searchcore
parentd5821ee392c7a71e4db6de446b4d6adf636552e7 (diff)
Update comments regarding sanity checks and lid space compaction
Diffstat (limited to 'searchcore')
-rw-r--r--searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job.cpp b/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job.cpp
index 4608f9c4959..7345a07cd27 100644
--- a/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job.cpp
+++ b/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job.cpp
@@ -34,11 +34,11 @@ namespace {
bool
isSameDocument(const search::DocumentMetaData &a, const search::DocumentMetaData &b) {
+ //TODO Timestamp check can be removed once logic has proved itself in large scale.
return (a.lid == b.lid) &&
(a.bucketId == b.bucketId) &&
(a.gid == b.gid) &&
- (a.timestamp ==
- b.timestamp); // Timestamp check can be removed once logic has proved itself in large scale.
+ (a.timestamp == b.timestamp);
}
}
@@ -111,7 +111,6 @@ CompactionJob::completeMove(const search::DocumentMetaData & metaThen, std::uniq
// Reread meta data as document might have been altered after move was initiated
// If so it will fail the timestamp sanity check later on.
search::DocumentMetaData metaNow = _handler->getMetaData(metaThen.lid);
- // This should be impossible and should probably be an assert
if ( ! isSameDocument(metaThen, metaNow)) return;
if (metaNow.gid != moveOp->getDocument()->getId().getGlobalId()) return;