summaryrefslogtreecommitdiffstats
path: root/searchcore
diff options
context:
space:
mode:
authorTor Egge <Tor.Egge@online.no>2023-02-13 14:33:55 +0100
committerTor Egge <Tor.Egge@online.no>2023-02-13 14:33:55 +0100
commit2681dae863cb729d154784433c0bdeb60f9992cc (patch)
tree8c8deaab4b2e0e1705408ef3a9b6aa2a72d61cf0 /searchcore
parent3da5e19509fcc10d4cdbcc49747cacc7cac2ae2e (diff)
Limit lid space blocking log messages to state transitions.
Diffstat (limited to 'searchcore')
-rw-r--r--searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job.cpp18
1 files changed, 11 insertions, 7 deletions
diff --git a/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job.cpp b/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job.cpp
index dcc19501dd1..27f735379d9 100644
--- a/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job.cpp
+++ b/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job.cpp
@@ -202,16 +202,20 @@ CompactionJob::run()
}
if (remove_batch_is_ongoing()) {
// Note that we don't set the job as blocked as the decision to un-block it is not driven externally.
- LOG(info, "%s: Lid space compaction is disabled while remove batch (delete buckets) is ongoing",
- _handler->getName().c_str());
- _is_disabled = true;
+ if (!_is_disabled) {
+ LOG(info, "%s: Lid space compaction is disabled while remove batch (delete buckets) is ongoing",
+ _handler->getName().c_str());
+ _is_disabled = true;
+ }
return true;
}
if (remove_is_ongoing()) {
// Note that we don't set the job as blocked as the decision to un-block it is not driven externally.
- LOG(info, "%s: Lid space compaction is disabled while remove operations are ongoing",
- _handler->getName().c_str());
- _is_disabled = true;
+ if (!_is_disabled) {
+ LOG(info, "%s: Lid space compaction is disabled while remove operations are ongoing",
+ _handler->getName().c_str());
+ _is_disabled = true;
+ }
return true;
}
if (_is_disabled) {
@@ -306,7 +310,7 @@ CompactionJob::notifyClusterStateChanged(const std::shared_ptr<IBucketStateCalcu
LOG(info, "%s: Lid space compaction is un-blocked as node is no longer retired", _handler->getName().c_str());
unBlock(BlockedReason::CLUSTER_STATE);
}
- } else {
+ } else if (!isBlocked(BlockedReason::CLUSTER_STATE)) {
LOG(info, "%s: Lid space compaction is blocked as node is retired", _handler->getName().c_str());
setBlocked(BlockedReason::CLUSTER_STATE);
}