summaryrefslogtreecommitdiffstats
path: root/searchcore
diff options
context:
space:
mode:
authorHåvard Pettersen <havardpe@oath.com>2017-09-29 15:08:18 +0000
committerHåvard Pettersen <havardpe@oath.com>2017-09-29 15:08:18 +0000
commit761041825bf2a01520d05ddca928182dfc798911 (patch)
treed16b7c9c6b6e6adae7e72036d09eafd5ef6e16c3 /searchcore
parent33868f33f656c44c6fc318d51297b1b336ede170 (diff)
avoid implicit cast to bool
Diffstat (limited to 'searchcore')
-rw-r--r--searchcore/src/tests/proton/docsummary/docsummary.cpp4
-rw-r--r--searchcore/src/tests/proton/docsummary/summaryfieldconverter_test.cpp2
-rw-r--r--searchcore/src/tests/proton/summaryengine/summaryengine.cpp4
3 files changed, 5 insertions, 5 deletions
diff --git a/searchcore/src/tests/proton/docsummary/docsummary.cpp b/searchcore/src/tests/proton/docsummary/docsummary.cpp
index 26b43d272aa..c2f536e9dda 100644
--- a/searchcore/src/tests/proton/docsummary/docsummary.cpp
+++ b/searchcore/src/tests/proton/docsummary/docsummary.cpp
@@ -461,12 +461,12 @@ Test::assertSlime(const std::string &exp, const DocsumReply &reply, uint32_t id,
vespalib::slime::JsonFormat::encode(slime, buf, false);
vespalib::Slime tmpSlime;
size_t used = vespalib::slime::JsonFormat::decode(buf.get(), tmpSlime);
- EXPECT_TRUE(used);
+ EXPECT_TRUE(used > 0);
slime = std::move(tmpSlime);
}
vespalib::Slime expSlime;
size_t used = vespalib::slime::JsonFormat::decode(exp, expSlime);
- EXPECT_TRUE(used);
+ EXPECT_TRUE(used > 0);
return EXPECT_EQUAL(expSlime, slime);
}
diff --git a/searchcore/src/tests/proton/docsummary/summaryfieldconverter_test.cpp b/searchcore/src/tests/proton/docsummary/summaryfieldconverter_test.cpp
index 6d646bf3f4b..2d0ff39efa4 100644
--- a/searchcore/src/tests/proton/docsummary/summaryfieldconverter_test.cpp
+++ b/searchcore/src/tests/proton/docsummary/summaryfieldconverter_test.cpp
@@ -119,7 +119,7 @@ FieldBlock::FieldBlock(const vespalib::string &jsonInput)
: input(jsonInput), slime(), binary(1024), json()
{
size_t used = vespalib::slime::JsonFormat::decode(jsonInput, slime);
- EXPECT_TRUE(used);
+ EXPECT_TRUE(used > 0);
{
search::SlimeOutputRawBufAdapter adapter(binary);
vespalib::slime::JsonFormat::encode(slime, adapter, true);
diff --git a/searchcore/src/tests/proton/summaryengine/summaryengine.cpp b/searchcore/src/tests/proton/summaryengine/summaryengine.cpp
index 9c4ce323e1e..db707e4aa97 100644
--- a/searchcore/src/tests/proton/summaryengine/summaryengine.cpp
+++ b/searchcore/src/tests/proton/summaryengine/summaryengine.cpp
@@ -213,12 +213,12 @@ verify(vespalib::stringref exp, const Slime &slime) {
Memory expMemory(exp);
vespalib::Slime expSlime;
size_t used = vespalib::slime::JsonFormat::decode(expMemory, expSlime);
- EXPECT_TRUE(used);
+ EXPECT_TRUE(used > 0);
vespalib::SimpleBuffer output;
vespalib::slime::JsonFormat::encode(slime, output, true);
Slime reSlimed;
used = vespalib::slime::JsonFormat::decode(output.get(), reSlimed);
- EXPECT_TRUE(used);
+ EXPECT_TRUE(used > 0);
EXPECT_EQUAL(expSlime, reSlimed);
}