summaryrefslogtreecommitdiffstats
path: root/searchcore
diff options
context:
space:
mode:
authorHåvard Pettersen <havardpe@oath.com>2021-10-08 10:22:03 +0000
committerHåvard Pettersen <havardpe@oath.com>2021-10-08 10:22:03 +0000
commita45f09c5edf40fdf01d18bfb92807c59f73defa3 (patch)
tree7bd28ad19cdeba916e96d900bc2bd9712e569dba /searchcore
parent2bf9f4d229580517ba228b6a6617bece324b41f1 (diff)
wait with actual reporting until we want errors
Diffstat (limited to 'searchcore')
-rw-r--r--searchcore/src/vespa/searchcore/grouping/groupingmanager.cpp7
1 files changed, 6 insertions, 1 deletions
diff --git a/searchcore/src/vespa/searchcore/grouping/groupingmanager.cpp b/searchcore/src/vespa/searchcore/grouping/groupingmanager.cpp
index 42c5d16162e..863511da5ee 100644
--- a/searchcore/src/vespa/searchcore/grouping/groupingmanager.cpp
+++ b/searchcore/src/vespa/searchcore/grouping/groupingmanager.cpp
@@ -61,7 +61,12 @@ GroupingManager::init(const IAttributeContext &attrCtx)
list.push_back(groupingList[i]);
} catch (const std::exception & e) {
auto msg = fmt("Could not locate attribute for grouping number %ld : %s. Ignoring grouping '%s'", i, e.what(), grouping.asString().c_str());
- Issue::report(msg);
+ //
+ // NOTE: if this issue is reported as an error in the
+ // search reply, the grouping searcher will discard all
+ // grouping results, which may or may not be what we want.
+ //
+ // Issue::report(msg);
LOG(error, "%s", msg.c_str());
}
}