summaryrefslogtreecommitdiffstats
path: root/searchcore
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2020-01-04 07:53:48 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2020-01-04 07:53:48 +0000
commit91767ed57d8f6e66b2fad8a031369220bf8d38aa (patch)
tree83b38644788cba3a57f02b250c28643fe843339c /searchcore
parent8f3cf5aa28519c85211812d218f9e63a7e605edd (diff)
No need for a shared_ptr here.
Diffstat (limited to 'searchcore')
-rw-r--r--searchcore/src/vespa/searchcore/proton/server/storeonlyfeedview.cpp6
-rw-r--r--searchcore/src/vespa/searchcore/proton/server/storeonlyfeedview.h2
2 files changed, 4 insertions, 4 deletions
diff --git a/searchcore/src/vespa/searchcore/proton/server/storeonlyfeedview.cpp b/searchcore/src/vespa/searchcore/proton/server/storeonlyfeedview.cpp
index f5213101721..93c74a11f93 100644
--- a/searchcore/src/vespa/searchcore/proton/server/storeonlyfeedview.cpp
+++ b/searchcore/src/vespa/searchcore/proton/server/storeonlyfeedview.cpp
@@ -464,7 +464,7 @@ StoreOnlyFeedView::internalUpdate(FeedToken token, const UpdateOperation &updOp)
[upd = updOp.getUpdate(), serialNum, lid, onWriteDone, promisedDoc = std::move(promisedDoc),
promisedStream = std::move(promisedStream), this]() mutable
{
- makeUpdatedDocument(serialNum, lid, std::move(upd), onWriteDone,
+ makeUpdatedDocument(serialNum, lid, *upd, onWriteDone,
std::move(promisedDoc), std::move(promisedStream));
});
#pragma GCC diagnostic pop
@@ -473,12 +473,12 @@ StoreOnlyFeedView::internalUpdate(FeedToken token, const UpdateOperation &updOp)
}
void
-StoreOnlyFeedView::makeUpdatedDocument(SerialNum serialNum, Lid lid, DocumentUpdate::SP update,
+StoreOnlyFeedView::makeUpdatedDocument(SerialNum serialNum, Lid lid, const DocumentUpdate & update,
OnOperationDoneType onWriteDone, PromisedDoc promisedDoc,
PromisedStream promisedStream)
{
Document::UP prevDoc = _summaryAdapter->get(lid, *_repo);
- const DocumentUpdate & upd = *update;
+ const DocumentUpdate & upd = update;
Document::UP newDoc;
vespalib::nbostream newStream(12345);
assert(!onWriteDone->hasToken() || useDocumentStore(serialNum));
diff --git a/searchcore/src/vespa/searchcore/proton/server/storeonlyfeedview.h b/searchcore/src/vespa/searchcore/proton/server/storeonlyfeedview.h
index 18b78642814..636434e58a7 100644
--- a/searchcore/src/vespa/searchcore/proton/server/storeonlyfeedview.h
+++ b/searchcore/src/vespa/searchcore/proton/server/storeonlyfeedview.h
@@ -189,7 +189,7 @@ private:
// Ack token early if visibility delay is nonzero
void considerEarlyAck(FeedToken &token);
- void makeUpdatedDocument(SerialNum serialNum, Lid lid, DocumentUpdateSP upd, OnOperationDoneType onWriteDone,
+ void makeUpdatedDocument(SerialNum serialNum, Lid lid, const DocumentUpdate & upd, OnOperationDoneType onWriteDone,
PromisedDoc promisedDoc, PromisedStream promisedStream);
protected: