simplify notImplemented()

* no need for notImplemented() to be virtual
* special version for documentmetastore does not seem to
  add any value
* ensure [[noreturn]] attribute actually works

2 files changed, 0 insertions, 12 deletions

diff --git a/searchcore/src/vespa/searchcore/proton/documentmetastore/documentmetastoreattribute.cpp b/searchcore/src/vespa/searchcore/proton/documentmetastore/documentmetastoreattribute.cpp
index 7fab995dfb9..fa8097419a5 100644
--- a/searchcore/src/vespa/searchcore/proton/documentmetastore/documentmetastoreattribute.cpp
+++ b/searchcore/src/vespa/searchcore/proton/documentmetastore/documentmetastoreattribute.cpp
@@ -17,15 +17,6 @@ DocumentMetaStoreAttribute::getFixedName()
     return _G_documentMetaStoreName;
 }
 
-
-void
-DocumentMetaStoreAttribute::notImplemented() const
-{
-    throw vespalib::IllegalStateException(
-            "The function is not implemented for DocumentMetaStoreAttribute");
-}
-
-
 DocumentMetaStoreAttribute::DocumentMetaStoreAttribute(const vespalib::string &name)
     : NotImplementedAttribute(name, Config(BasicType::NONE))
 { }
diff --git a/searchcore/src/vespa/searchcore/proton/documentmetastore/documentmetastoreattribute.h b/searchcore/src/vespa/searchcore/proton/documentmetastore/documentmetastoreattribute.h
index 721aa8fe126..f4e936e663a 100644
--- a/searchcore/src/vespa/searchcore/proton/documentmetastore/documentmetastoreattribute.h
+++ b/searchcore/src/vespa/searchcore/proton/documentmetastore/documentmetastoreattribute.h
@@ -13,9 +13,6 @@ namespace proton {
  **/
 class DocumentMetaStoreAttribute : public search::NotImplementedAttribute
 {
-protected:
-    void notImplemented() const override __attribute__((noinline));
-
 public:
     DocumentMetaStoreAttribute(const vespalib::string &name=getFixedName());
     ~DocumentMetaStoreAttribute() override;