diff options
author | Tor Egge <Tor.Egge@broadpark.no> | 2020-09-25 13:17:16 +0200 |
---|---|---|
committer | Tor Egge <Tor.Egge@broadpark.no> | 2020-09-25 13:18:08 +0200 |
commit | 620aea4f309ca930372906c27048e64b542dd942 (patch) | |
tree | 75b3000db129ea394fbc1765b608819738b64bac /searchcore | |
parent | e37c257c1ca3d78f7ea00a808f1d0c710ae5e577 (diff) |
Add comment describing why commit() should not be called during replay.
Diffstat (limited to 'searchcore')
-rw-r--r-- | searchcore/src/vespa/searchcore/proton/server/documentdb.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/searchcore/src/vespa/searchcore/proton/server/documentdb.cpp b/searchcore/src/vespa/searchcore/proton/server/documentdb.cpp index 20f8853a722..c63785faa35 100644 --- a/searchcore/src/vespa/searchcore/proton/server/documentdb.cpp +++ b/searchcore/src/vespa/searchcore/proton/server/documentdb.cpp @@ -911,6 +911,13 @@ DocumentDB::syncFeedView() IFeedView::SP newFeedView(_subDBs.getFeedView()); _writeService.sync(); + /* + * Don't call commit() on visibility handler during transaction + * log replay since the serial number used for the commit will be + * too high until the replay is complete. This check can be + * removed again when feed handler has improved tracking of serial + * numbers during replay. + */ if (_state.getAllowReconfig()) { _visibility.commit(); } |