diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2021-11-23 15:02:04 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-11-23 15:02:04 +0100 |
commit | 7425efd22de76f883dd2c3d8c15a82a205bb3a18 (patch) | |
tree | 4e6d6cb445f8d2cb7ce74dfa13cd2e8d6e0396f2 /searchcore | |
parent | e319a7b64053d221f91d36754fecefabeff0d727 (diff) |
Revert "Go back to using sync"
Diffstat (limited to 'searchcore')
-rw-r--r-- | searchcore/src/tests/proton/documentdb/feedview/feedview_test.cpp | 4 | ||||
-rw-r--r-- | searchcore/src/vespa/searchcore/proton/server/fast_access_feed_view.cpp | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/searchcore/src/tests/proton/documentdb/feedview/feedview_test.cpp b/searchcore/src/tests/proton/documentdb/feedview/feedview_test.cpp index 363c2925491..a030ce1c455 100644 --- a/searchcore/src/tests/proton/documentdb/feedview/feedview_test.cpp +++ b/searchcore/src/tests/proton/documentdb/feedview/feedview_test.cpp @@ -1137,7 +1137,7 @@ TEST_F("require that compactLidSpace() propagates to document meta store and doc f.compactLidSpaceAndWait(2); // performIndexForceCommit in index thread, then completion callback // in master thread. - EXPECT_TRUE(assertThreadObserver(7, 6, 6, f.writeServiceObserver())); + EXPECT_TRUE(assertThreadObserver(7, 7, 7, f.writeServiceObserver())); EXPECT_EQUAL(2u, f.metaStoreObserver()._compactLidSpaceLidLimit); EXPECT_EQUAL(2u, f.getDocumentStore()._compactLidSpaceLidLimit); EXPECT_EQUAL(1u, f.metaStoreObserver()._holdUnblockShrinkLidSpaceCnt); @@ -1155,7 +1155,7 @@ TEST_F("require that compactLidSpace() doesn't propagate to " op.setSerialNum(0); f.runInMasterAndSyncAll([&]() { f.fv.handleCompactLidSpace(op); }); // Delayed holdUnblockShrinkLidSpace() in index thread, then master thread - EXPECT_TRUE(assertThreadObserver(6, 5, 4, f.writeServiceObserver())); + EXPECT_TRUE(assertThreadObserver(6, 6, 5, f.writeServiceObserver())); EXPECT_EQUAL(0u, f.metaStoreObserver()._compactLidSpaceLidLimit); EXPECT_EQUAL(0u, f.getDocumentStore()._compactLidSpaceLidLimit); EXPECT_EQUAL(0u, f.metaStoreObserver()._holdUnblockShrinkLidSpaceCnt); diff --git a/searchcore/src/vespa/searchcore/proton/server/fast_access_feed_view.cpp b/searchcore/src/vespa/searchcore/proton/server/fast_access_feed_view.cpp index db2bb7ed2cb..e2b3887c60c 100644 --- a/searchcore/src/vespa/searchcore/proton/server/fast_access_feed_view.cpp +++ b/searchcore/src/vespa/searchcore/proton/server/fast_access_feed_view.cpp @@ -6,7 +6,6 @@ #include "removedonecontext.h" #include "putdonecontext.h" #include <vespa/searchcore/proton/feedoperation/operations.h> -#include <vespa/vespalib/util/isequencedtaskexecutor.h> using document::Document; using document::DocumentUpdate; @@ -73,7 +72,7 @@ void FastAccessFeedView::handleCompactLidSpace(const CompactLidSpaceOperation &op) { // Drain pending PutDoneContext and ForceCommitContext objects - _writeService.sync_all_executors(); + forceCommitAndWait(search::CommitParam(op.getSerialNum())); _docIdLimit.set(op.getLidLimit()); getAttributeWriter()->compactLidSpace(op.getLidLimit(), op.getSerialNum()); Parent::handleCompactLidSpace(op); |