Don't apply remove to attribute if last sync token on attribute is equal to serialNum.

Several years ago, attribute vector last sync token was updated for each
write operation, and lid space compaction generated a move operation that
performed two write operations on the same attribute with the same serial
number (setting the value for the new lid and clearing the value for
the old lid). Current code delays update of attribute vector last sync token
until a force commit operation or an attribute vector flush (to disk).

1 files changed, 1 insertions, 2 deletions

diff --git a/searchcore/src/vespa/searchcore/proton/attribute/attribute_writer.cpp b/searchcore/src/vespa/searchcore/proton/attribute/attribute_writer.cpp
index 418615058ce..cb061309d75 100644
--- a/searchcore/src/vespa/searchcore/proton/attribute/attribute_writer.cpp
+++ b/searchcore/src/vespa/searchcore/proton/attribute/attribute_writer.cpp
@@ -518,8 +518,7 @@ RemoveTask::run()
     const auto &fields = _wc.getFields();
     for (auto &field : fields) {
         AttributeVector &attr = field.getAttribute();
-        // Must use <= due to how move operations are handled
-        if (attr.getStatus().getLastSyncToken() <= _serialNum) {
+        if (attr.getStatus().getLastSyncToken() < _serialNum) {
             applyRemoveToAttribute(_serialNum, _lid, attr, _onWriteDone);
         }
     }