diff options
author | Jon Bratseth <bratseth@gmail.com> | 2023-03-10 18:31:05 +0100 |
---|---|---|
committer | Jon Bratseth <bratseth@gmail.com> | 2023-03-10 18:31:05 +0100 |
commit | 315c1feec1ac67f97419d910550f4aebfe9290a7 (patch) | |
tree | bb5ae526f63fd22cad1533950c151f4047a11d1d /searchlib/src/main | |
parent | 3881033cffca4d8461c076e26717d9493c3bac13 (diff) |
Cooldown from completion rather than start of scaling
Diffstat (limited to 'searchlib/src/main')
2 files changed, 3 insertions, 6 deletions
diff --git a/searchlib/src/main/java/com/yahoo/searchlib/rankingexpression/evaluation/gbdtoptimization/GBDTForestOptimizer.java b/searchlib/src/main/java/com/yahoo/searchlib/rankingexpression/evaluation/gbdtoptimization/GBDTForestOptimizer.java index a3fc6aae9ac..92aa65eac99 100644 --- a/searchlib/src/main/java/com/yahoo/searchlib/rankingexpression/evaluation/gbdtoptimization/GBDTForestOptimizer.java +++ b/searchlib/src/main/java/com/yahoo/searchlib/rankingexpression/evaluation/gbdtoptimization/GBDTForestOptimizer.java @@ -48,9 +48,8 @@ public class GBDTForestOptimizer extends Optimizer { */ private ExpressionNode findAndOptimize(ExpressionNode node) { ExpressionNode newNode = optimize(node); - if ( ! (newNode instanceof CompositeNode)) return newNode; // + if ( ! (newNode instanceof CompositeNode newComposite)) return newNode; - CompositeNode newComposite = (CompositeNode)newNode; List<ExpressionNode> newChildren = new ArrayList<>(); for (ExpressionNode child : newComposite.children()) { newChildren.add(findAndOptimize(child)); @@ -84,10 +83,9 @@ public class GBDTForestOptimizer extends Optimizer { currentTreesOptimized++; return true; } - if (!(node instanceof OperationNode)) { + if (!(node instanceof OperationNode aNode)) { return false; } - OperationNode aNode = (OperationNode)node; for (Operator op : aNode.operators()) { if (op != Operator.plus) { return false; diff --git a/searchlib/src/main/java/com/yahoo/searchlib/rankingexpression/evaluation/gbdtoptimization/GBDTOptimizer.java b/searchlib/src/main/java/com/yahoo/searchlib/rankingexpression/evaluation/gbdtoptimization/GBDTOptimizer.java index 7ba671e62eb..eb79c8ba2c1 100644 --- a/searchlib/src/main/java/com/yahoo/searchlib/rankingexpression/evaluation/gbdtoptimization/GBDTOptimizer.java +++ b/searchlib/src/main/java/com/yahoo/searchlib/rankingexpression/evaluation/gbdtoptimization/GBDTOptimizer.java @@ -95,8 +95,7 @@ public class GBDTOptimizer extends Optimizer { */ private int consumeNode(ExpressionNode node, List<Double> values, ContextIndex context) { int beforeIndex = values.size(); - if ( node instanceof IfNode) { - IfNode ifNode = (IfNode)node; + if (node instanceof IfNode ifNode) { int jumpValueIndex = consumeIfCondition(ifNode.getCondition(), values, context); values.add(0d); // jumpValue goes here after the next line int jumpValue = consumeNode(ifNode.getTrueExpression(), values, context) + 1; |