aboutsummaryrefslogtreecommitdiffstats
path: root/searchlib/src/tests/attribute/attribute_test.cpp
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2022-05-27 18:51:20 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2022-05-27 18:51:20 +0000
commit4802b8fdcf1f7621d48acdae343a25e83ebe1b85 (patch)
tree2fed6d2d81e038f13f730557558e35d6a637fc65 /searchlib/src/tests/attribute/attribute_test.cpp
parent23e9dd2577e9d5bd32e410e2759a82aad6e185ee (diff)
Avoid using vespalib::Identifiable.
Diffstat (limited to 'searchlib/src/tests/attribute/attribute_test.cpp')
-rw-r--r--searchlib/src/tests/attribute/attribute_test.cpp18
1 files changed, 10 insertions, 8 deletions
diff --git a/searchlib/src/tests/attribute/attribute_test.cpp b/searchlib/src/tests/attribute/attribute_test.cpp
index 64edb30520b..fbfe203ee9e 100644
--- a/searchlib/src/tests/attribute/attribute_test.cpp
+++ b/searchlib/src/tests/attribute/attribute_test.cpp
@@ -1,10 +1,6 @@
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
-#include <vespa/document/fieldvalue/intfieldvalue.h>
-#include <vespa/document/fieldvalue/stringfieldvalue.h>
-#include <vespa/document/update/arithmeticvalueupdate.h>
-#include <vespa/document/update/assignvalueupdate.h>
-#include <vespa/document/update/mapvalueupdate.h>
+
#include <vespa/searchlib/attribute/address_space_components.h>
#include <vespa/searchlib/attribute/attribute.h>
#include <vespa/searchlib/attribute/attributefactory.h>
@@ -20,11 +16,17 @@
#include <vespa/searchlib/index/dummyfileheadercontext.h>
#include <vespa/searchlib/test/weighted_type_test_utils.h>
#include <vespa/searchlib/util/randomgenerator.h>
+#include <vespa/document/fieldvalue/intfieldvalue.h>
+#include <vespa/document/fieldvalue/stringfieldvalue.h>
+#include <vespa/document/update/arithmeticvalueupdate.h>
+#include <vespa/document/update/assignvalueupdate.h>
+#include <vespa/document/update/mapvalueupdate.h>
#include <vespa/vespalib/io/fileutil.h>
#include <vespa/vespalib/gtest/gtest.h>
#include <vespa/vespalib/util/mmap_file_allocator_factory.h>
#include <vespa/vespalib/util/round_up_to_page_size.h>
#include <vespa/vespalib/util/size_literals.h>
+#include <vespa/vespalib/stllike/asciistream.h>
#include <vespa/fastos/file.h>
#include <cmath>
#include <iostream>
@@ -1412,7 +1414,7 @@ AttributeTest::testArithmeticValueUpdate(const AttributePtr & ptr)
ASSERT_TRUE(vec.update(0, 100));
EXPECT_TRUE(vec.apply(0, Arith(Arith::Div, 0)));
ptr->commit();
- if (ptr->getClass().inherits(FloatingPointAttribute::classId)) {
+ if (ptr->isFloatingPointType()) {
EXPECT_EQ(ptr->getStatus().getUpdateCount(), 86u);
EXPECT_EQ(ptr->getStatus().getNonIdempotentUpdateCount(), 66u);
} else { // does not apply for interger attributes
@@ -1427,7 +1429,7 @@ AttributeTest::testArithmeticValueUpdate(const AttributePtr & ptr)
// try divide by zero with empty change vector
EXPECT_TRUE(vec.apply(0, Arith(Arith::Div, 0)));
ptr->commit();
- if (ptr->getClass().inherits(FloatingPointAttribute::classId)) {
+ if (ptr->isFloatingPointType()) {
EXPECT_EQ(ptr->getStatus().getUpdateCount(), 87u);
EXPECT_EQ(ptr->getStatus().getNonIdempotentUpdateCount(), 67u);
} else { // does not apply for interger attributes
@@ -1486,7 +1488,7 @@ AttributeTest::testArithmeticWithUndefinedValue(const AttributePtr & ptr, BaseTy
std::vector<BufferType> buf(1);
ptr->get(0, &buf[0], 1);
- if (ptr->getClass().inherits(FloatingPointAttribute::classId)) {
+ if (ptr->isFloatingPointType()) {
EXPECT_TRUE(std::isnan(buf[0]));
} else {
EXPECT_EQ(buf[0], after);