diff options
| author | Håvard Pettersen <havardpe@yahooinc.com> | 2022-06-07 13:28:03 +0000 |
|---|---|---|
| committer | Håvard Pettersen <havardpe@yahooinc.com> | 2022-06-07 14:26:07 +0000 |
| commit | dc21b2810fce181a1ce867c88c641d3826d1e0e1 (patch) | |
| tree | fe82f47c3de77b2351d43c64a155df92b85e33a8 /searchlib/src/tests/expression | |
| parent | 7225d00b6c3fbd464e40b199e2088fb7a00552a9 (diff) | |
expression result is pointer
since it can sometimes be nullptr
(deref of nullptr is undefined behavior)
Diffstat (limited to 'searchlib/src/tests/expression')
| -rw-r--r-- | searchlib/src/tests/expression/attributenode/attribute_node_test.cpp | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/searchlib/src/tests/expression/attributenode/attribute_node_test.cpp b/searchlib/src/tests/expression/attributenode/attribute_node_test.cpp index 059f198a070..896fd27f90e 100644 --- a/searchlib/src/tests/expression/attributenode/attribute_node_test.cpp +++ b/searchlib/src/tests/expression/attributenode/attribute_node_test.cpp @@ -251,7 +251,7 @@ Fixture::assertInts(std::vector<IAttributeVector::largeint_t> expVals, const ves ++docId; node->setDocId(docId); node->execute(); - const auto &result = node->getResult(); + const auto &result = *node->getResult(); if (preserveAccurateTypes) { ASSERT_TRUE(result.inherits(Int8ResultNode::classId)); } else { @@ -271,7 +271,7 @@ Fixture::assertBools(std::vector<bool> expVals, const vespalib::string &attribut ++docId; node->setDocId(docId); node->execute(); - const auto &result = node->getResult(); + const auto &result = *node->getResult(); ASSERT_TRUE(result.inherits(BoolResultNode::classId)); const BoolResultNode & bResult = static_cast<const BoolResultNode &>(result); @@ -290,7 +290,7 @@ Fixture::assertStrings(std::vector<vespalib::string> expVals, const vespalib::st ++docId; node->setDocId(docId); node->execute(); - const auto &result = node->getResult(); + const auto &result = *node->getResult(); if (useEnumOptimization) { ASSERT_TRUE(result.inherits(EnumResultNode::classId)); } else { @@ -310,7 +310,7 @@ Fixture::assertFloats(std::vector<double> expVals, const vespalib::string &attri ++docId; node->setDocId(docId); node->execute(); - const auto &result = node->getResult(); + const auto &result = *node->getResult(); ASSERT_TRUE(result.inherits(FloatResultNode::classId)); double docVal = result.getFloat(); EXPECT_EQUAL(std::isnan(expDocVal), std::isnan(docVal)); @@ -329,7 +329,7 @@ Fixture::assertIntArrays(std::vector<std::vector<IAttributeVector::largeint_t>> ++docId; node->setDocId(docId); node->execute(); - const auto &result = node->getResult(); + const auto &result = *node->getResult(); ASSERT_TRUE(result.inherits(ResultNodeVector::classId)); const auto &resultVector = static_cast<const ResultNodeVector &>(result); if (preserveAccurateTypes) { @@ -354,7 +354,7 @@ Fixture::assertStringArrays(std::vector<std::vector<vespalib::string>> expVals, ++docId; node->setDocId(docId); node->execute(); - const auto &result = node->getResult(); + const auto &result = *node->getResult(); ASSERT_TRUE(result.inherits(ResultNodeVector::classId)); const auto &resultVector = static_cast<const ResultNodeVector &>(result); if (useEnumOptimization) { @@ -379,7 +379,7 @@ Fixture::assertFloatArrays(std::vector<std::vector<double>> expVals, const vespa ++docId; node->setDocId(docId); node->execute(); - const auto &result = node->getResult(); + const auto &result = *node->getResult(); ASSERT_TRUE(result.inherits(ResultNodeVector::classId)); const auto &resultVector = static_cast<const ResultNodeVector &>(result); ASSERT_TRUE(result.inherits(FloatResultNodeVector::classId)); |