diff options
| author | Tor Egge <Tor.Egge@broadpark.no> | 2019-05-24 15:42:15 +0200 |
|---|---|---|
| committer | Tor Egge <Tor.Egge@broadpark.no> | 2019-05-24 15:45:39 +0200 |
| commit | 02a609771b48d46270e3c0a90bf8a7c0656143b5 (patch) | |
| tree | db0df2c76d143903ffbafbfa74c7923e2eec03a1 /searchlib/src/tests/fef | |
| parent | d06ec4eac1df145e6b52edf3734a3f130a9ffc02 (diff) | |
Refactor tagging of TermFieldMatchData regarding which features are
needed by feature executors.
Diffstat (limited to 'searchlib/src/tests/fef')
| -rw-r--r-- | searchlib/src/tests/fef/termfieldmodel/termfieldmodel_test.cpp | 25 |
1 files changed, 23 insertions, 2 deletions
diff --git a/searchlib/src/tests/fef/termfieldmodel/termfieldmodel_test.cpp b/searchlib/src/tests/fef/termfieldmodel/termfieldmodel_test.cpp index ca9e331bb62..9ed94c02287 100644 --- a/searchlib/src/tests/fef/termfieldmodel/termfieldmodel_test.cpp +++ b/searchlib/src/tests/fef/termfieldmodel/termfieldmodel_test.cpp @@ -256,12 +256,33 @@ TEST("require that TermFieldMatchData can be tagged as needed or not") { tfmd.setFieldId(123); EXPECT_EQUAL(tfmd.getFieldId(),123u); EXPECT_TRUE(!tfmd.isNotNeeded()); + EXPECT_TRUE(tfmd.needs_normal_features()); + EXPECT_TRUE(tfmd.needs_cheap_features()); tfmd.tagAsNotNeeded(); EXPECT_EQUAL(tfmd.getFieldId(),123u); EXPECT_TRUE(tfmd.isNotNeeded()); - tfmd.tagAsNeeded(); + EXPECT_TRUE(!tfmd.needs_normal_features()); + EXPECT_TRUE(!tfmd.needs_cheap_features()); + tfmd.setNeedNormalFeatures(true); EXPECT_EQUAL(tfmd.getFieldId(),123u); EXPECT_TRUE(!tfmd.isNotNeeded()); + EXPECT_TRUE(tfmd.needs_normal_features()); + EXPECT_TRUE(!tfmd.needs_cheap_features()); + tfmd.setNeedCheapFeatures(true); + EXPECT_EQUAL(tfmd.getFieldId(),123u); + EXPECT_TRUE(!tfmd.isNotNeeded()); + EXPECT_TRUE(tfmd.needs_normal_features()); + EXPECT_TRUE(tfmd.needs_cheap_features()); + tfmd.setNeedNormalFeatures(false); + EXPECT_EQUAL(tfmd.getFieldId(),123u); + EXPECT_TRUE(!tfmd.isNotNeeded()); + EXPECT_TRUE(!tfmd.needs_normal_features()); + EXPECT_TRUE(tfmd.needs_cheap_features()); + tfmd.setNeedCheapFeatures(false); + EXPECT_EQUAL(tfmd.getFieldId(),123u); + EXPECT_TRUE(tfmd.isNotNeeded()); + EXPECT_TRUE(!tfmd.needs_normal_features()); + EXPECT_TRUE(!tfmd.needs_cheap_features()); } TEST("require that MatchData soft_reset retains appropriate state") { @@ -280,7 +301,7 @@ TEST("require that MatchData soft_reset retains appropriate state") { auto *new_term = md->resolveTermField(7); EXPECT_EQUAL(new_term, old_term); EXPECT_EQUAL(md->get_termwise_limit(), 1.0); - EXPECT_TRUE(!new_term->isNotNeeded()); + EXPECT_TRUE(new_term->isNotNeeded()); EXPECT_EQUAL(new_term->getFieldId(), 7u); EXPECT_EQUAL(new_term->getWeight(), 21); EXPECT_EQUAL(new_term->getDocId(), TermFieldMatchData::invalidId()); |