diff options
author | Haavard <havardpe@yahoo-inc.com> | 2016-09-02 13:01:37 +0000 |
---|---|---|
committer | Haavard <havardpe@yahoo-inc.com> | 2016-09-02 14:27:36 +0000 |
commit | 61400a4b3e910c650c5648374eb921f49968fc12 (patch) | |
tree | 418201a2411ed18f00e88a9167faf3dd19e279ee /searchlib/src/tests/queryeval/blueprint | |
parent | a04647ceea6852cba7f2a8b6bd51cf7d796fa4e8 (diff) |
do not copy blueprints, freeze blueprints
Diffstat (limited to 'searchlib/src/tests/queryeval/blueprint')
-rw-r--r-- | searchlib/src/tests/queryeval/blueprint/blueprint_test.cpp | 9 | ||||
-rw-r--r-- | searchlib/src/tests/queryeval/blueprint/leaf_blueprints_test.cpp | 23 |
2 files changed, 10 insertions, 22 deletions
diff --git a/searchlib/src/tests/queryeval/blueprint/blueprint_test.cpp b/searchlib/src/tests/queryeval/blueprint/blueprint_test.cpp index 79fec3770b3..7fcb1c20932 100644 --- a/searchlib/src/tests/queryeval/blueprint/blueprint_test.cpp +++ b/searchlib/src/tests/queryeval/blueprint/blueprint_test.cpp @@ -651,17 +651,8 @@ Test::testBlueprintMakeNew() orig->setSourceId(42); MyOr *myOr = dynamic_cast<MyOr*>(orig.get()); ASSERT_TRUE(myOr != 0); - Blueprint::UP copy1 = makeNew(myOr); - Blueprint::UP copy2 = makeNew(myOr); - TEST_DO(check_equal(*copy1, *copy2)); - TEST_DO(check_not_equal(*orig, *copy1)); - TEST_DO(check_not_equal(*orig, *copy2)); - EXPECT_TRUE(dynamic_cast<MyOr*>(copy1.get()) != 0); - EXPECT_TRUE(dynamic_cast<MyOr*>(copy2.get()) != 0); EXPECT_EQUAL(42u, orig->getSourceId()); - EXPECT_EQUAL(42u, copy1->getSourceId()); EXPECT_EQUAL(2u, orig->getState().numFields()); - EXPECT_EQUAL(0u, copy1->getState().numFields()); } vespalib::string diff --git a/searchlib/src/tests/queryeval/blueprint/leaf_blueprints_test.cpp b/searchlib/src/tests/queryeval/blueprint/leaf_blueprints_test.cpp index a2353184c9f..6efa3454d01 100644 --- a/searchlib/src/tests/queryeval/blueprint/leaf_blueprints_test.cpp +++ b/searchlib/src/tests/queryeval/blueprint/leaf_blueprints_test.cpp @@ -24,13 +24,12 @@ Test::testEmptyBlueprint() { MatchData::UP md(MatchData::makeTestInstance(0, 100, 10)); EmptyBlueprint empty(FieldSpecBase(1, 11)); - EmptyBlueprint copy(empty); - ASSERT_TRUE(copy.getState().numFields() == 1u); - EXPECT_EQUAL(1u, copy.getState().field(0).getFieldId()); - EXPECT_EQUAL(11u, copy.getState().field(0).getHandle()); + ASSERT_TRUE(empty.getState().numFields() == 1u); + EXPECT_EQUAL(1u, empty.getState().field(0).getFieldId()); + EXPECT_EQUAL(11u, empty.getState().field(0).getHandle()); - copy.fetchPostings(true); - SearchIterator::UP search = copy.createSearch(*md, true); + empty.fetchPostings(true); + SearchIterator::UP search = empty.createSearch(*md, true); SimpleResult res; res.search(*search); @@ -46,10 +45,9 @@ Test::testSimpleBlueprint() a.addHit(3).addHit(5).addHit(7); SimpleBlueprint simple(a); simple.tag("tag"); - SimpleBlueprint copy(simple); - EXPECT_EQUAL("tag", copy.tag()); - copy.fetchPostings(true); - SearchIterator::UP search = copy.createSearch(*md, true); + EXPECT_EQUAL("tag", simple.tag()); + simple.fetchPostings(true); + SearchIterator::UP search = simple.createSearch(*md, true); SimpleResult res; res.search(*search); @@ -69,10 +67,9 @@ Test::testFakeBlueprint() uint32_t fieldId = 0; TermFieldHandle handle = 0; FakeBlueprint orig(FieldSpec("<field>", fieldId, handle), fake); - FakeBlueprint copy(orig); - copy.fetchPostings(true); - SearchIterator::UP search = copy.createSearch(*md, true); + orig.fetchPostings(true); + SearchIterator::UP search = orig.createSearch(*md, true); search->initFullRange(); EXPECT_TRUE(!search->seek(1u)); EXPECT_EQUAL(10u, search->getDocId()); |