summaryrefslogtreecommitdiffstats
path: root/searchlib/src/tests/util/sigbushandler/sigbushandler_test.cpp
diff options
context:
space:
mode:
authorArne Juul <arnej@yahoo-inc.com>2018-06-12 12:50:28 +0200
committerArne Juul <arnej@yahoo-inc.com>2018-06-12 13:51:45 +0200
commit016e584f0ad5a071e13d75eb8ad5ddb46b8c54f5 (patch)
tree869d4e4a4c4b8a9f9ef691b2980009017dece9e6 /searchlib/src/tests/util/sigbushandler/sigbushandler_test.cpp
parent22796dddd3dc025018093783328ac87535ffecd9 (diff)
use LOG_ABORT not just abort()
* abort() has the unfortunate effect that nothing is seen in the log, just an event (which is usually not displayed); so ops people don't see that the program is crashing at all. * LOG_ABORT("message") will log an error with the message (and the file and line) before calling abort(), so it's easy to see what happened. * add or move <vespa/log/log.h> include and LOG_SETUP lines before LOG_ABORT is used (or included).
Diffstat (limited to 'searchlib/src/tests/util/sigbushandler/sigbushandler_test.cpp')
-rw-r--r--searchlib/src/tests/util/sigbushandler/sigbushandler_test.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/searchlib/src/tests/util/sigbushandler/sigbushandler_test.cpp b/searchlib/src/tests/util/sigbushandler/sigbushandler_test.cpp
index c86a1c86dbb..1253cab4a74 100644
--- a/searchlib/src/tests/util/sigbushandler/sigbushandler_test.cpp
+++ b/searchlib/src/tests/util/sigbushandler/sigbushandler_test.cpp
@@ -64,7 +64,7 @@ TEST("Test that sigbus handler can trap synthetic sigbus")
sbh.setUnwind(&sjb);
kill(getpid(), SIGBUS);
LOG(error, "Should never get here");
- abort();
+ LOG_ABORT("should not be reached");
}
EXPECT_TRUE(sbh.fired());
{
@@ -101,7 +101,7 @@ TEST("Test that sigbus handler can trap normal sigbus")
sbh.setUnwind(&sjb);
r = *p;
LOG(error, "Should never get here");
- abort();
+ LOG_ABORT("should not be reached");
}
EXPECT_TRUE(sbh.fired());
EXPECT_TRUE(r == '\0');