diff options
| author | Henning Baldersheim <balder@yahoo-inc.com> | 2020-06-23 06:28:36 +0000 |
|---|---|---|
| committer | Henning Baldersheim <balder@yahoo-inc.com> | 2020-06-23 06:28:36 +0000 |
| commit | 52b404f36e13de8db4bc7cab3d82ea8073ccbd5d (patch) | |
| tree | b9ef56579e5e86ab4c6d7cd3814d55fdfbcab956 /searchlib/src | |
| parent | b56785323aaf66f1db473db130c2126ffdd76b9b (diff) | |
Follow up on PR comments.
Diffstat (limited to 'searchlib/src')
| -rw-r--r-- | searchlib/src/tests/features/prod_features.cpp | 2 | ||||
| -rw-r--r-- | searchlib/src/vespa/searchlib/features/uniquefeature.cpp | 5 | ||||
| -rw-r--r-- | searchlib/src/vespa/searchlib/features/uniquefeature.h | 2 |
3 files changed, 3 insertions, 6 deletions
diff --git a/searchlib/src/tests/features/prod_features.cpp b/searchlib/src/tests/features/prod_features.cpp index d28c162bacc..c50c7a12698 100644 --- a/searchlib/src/tests/features/prod_features.cpp +++ b/searchlib/src/tests/features/prod_features.cpp @@ -1575,8 +1575,6 @@ Test::testUnique() StringList params, in, out; FT_SETUP_OK(bp, ft.getIndexEnv(), params, in, out.add("out")); FT_DUMP_EMPTY(_factory, "unique"); - - EXPECT_TRUE(assertMatches(0, "x", "a", "matches(foo)")); } FtFeatureTest ft(_factory, "unique"); ASSERT_TRUE(ft.setup()); diff --git a/searchlib/src/vespa/searchlib/features/uniquefeature.cpp b/searchlib/src/vespa/searchlib/features/uniquefeature.cpp index 36876cd48ff..73ac4a1178e 100644 --- a/searchlib/src/vespa/searchlib/features/uniquefeature.cpp +++ b/searchlib/src/vespa/searchlib/features/uniquefeature.cpp @@ -1,4 +1,4 @@ -// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. +// Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. #include "uniquefeature.h" #include <vespa/vespalib/util/stash.h> @@ -42,8 +42,7 @@ UniqueBlueprint::visitDumpFeatures(const IIndexEnvironment &, IDumpFeatureVisito } bool -UniqueBlueprint::setup(const IIndexEnvironment & env, - const ParameterList & ) +UniqueBlueprint::setup(const IIndexEnvironment & env, const ParameterList & ) { _distributionKey = env.getDistributionKey(); describeOutput("out", "Returns (lid << 16) | distributionKey"); diff --git a/searchlib/src/vespa/searchlib/features/uniquefeature.h b/searchlib/src/vespa/searchlib/features/uniquefeature.h index 57c4f894e42..f21a427762a 100644 --- a/searchlib/src/vespa/searchlib/features/uniquefeature.h +++ b/searchlib/src/vespa/searchlib/features/uniquefeature.h @@ -7,7 +7,7 @@ namespace search::features { /** - * Implements the blueprint for the unique . + * Implements the blueprint for the unique rank feature. * * This will compute a globally unique id based on lid and distribution key. * Cheap way to get deterministic ordering |