no need to copy by value here either

5 files changed, 5 insertions, 5 deletions

diff --git a/searchlib/src/vespa/searchlib/tensor/i_tensor_attribute.h b/searchlib/src/vespa/searchlib/tensor/i_tensor_attribute.h
index f5481a680a3..c962e919d95 100644
--- a/searchlib/src/vespa/searchlib/tensor/i_tensor_attribute.h
+++ b/searchlib/src/vespa/searchlib/tensor/i_tensor_attribute.h
@@ -26,7 +26,7 @@ public:
     virtual bool supports_extract_dense_view() const = 0;
     virtual bool supports_get_tensor_ref() const = 0;
 
-    virtual vespalib::eval::ValueType getTensorType() const = 0;
+    virtual const vespalib::eval::ValueType & getTensorType() const = 0;
 
     /**
      * Gets custom state for this tensor attribute by inserting it into the given Slime inserter.
diff --git a/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector_read_guard.cpp b/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector_read_guard.cpp
index 1e376faa4d3..6a0dbfb9f48 100644
--- a/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector_read_guard.cpp
+++ b/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector_read_guard.cpp
@@ -60,7 +60,7 @@ ImportedTensorAttributeVectorReadGuard::get_tensor_ref(uint32_t docid) const
     return _target_tensor_attribute.get_tensor_ref(getTargetLid(docid));
 }
 
-vespalib::eval::ValueType
+const vespalib::eval::ValueType &
 ImportedTensorAttributeVectorReadGuard::getTensorType() const
 {
     return _target_tensor_attribute.getTensorType();
diff --git a/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector_read_guard.h b/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector_read_guard.h
index 3abac4e532e..a3ffc27b153 100644
--- a/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector_read_guard.h
+++ b/searchlib/src/vespa/searchlib/tensor/imported_tensor_attribute_vector_read_guard.h
@@ -36,7 +36,7 @@ public:
     const vespalib::eval::Value& get_tensor_ref(uint32_t docid) const override;
     bool supports_extract_dense_view() const override { return _target_tensor_attribute.supports_extract_dense_view(); }
     bool supports_get_tensor_ref() const override { return _target_tensor_attribute.supports_get_tensor_ref(); }
-    vespalib::eval::ValueType getTensorType() const override;
+    const vespalib::eval::ValueType &getTensorType() const override;
     void get_state(const vespalib::slime::Inserter& inserter) const override;
 };
 
diff --git a/searchlib/src/vespa/searchlib/tensor/tensor_attribute.cpp b/searchlib/src/vespa/searchlib/tensor/tensor_attribute.cpp
index 39e35af3174..0748329694c 100644
--- a/searchlib/src/vespa/searchlib/tensor/tensor_attribute.cpp
+++ b/searchlib/src/vespa/searchlib/tensor/tensor_attribute.cpp
@@ -202,7 +202,7 @@ TensorAttribute::get_tensor_ref(uint32_t docid) const
     abort(); // Needed to avoid compile error
 }
 
-vespalib::eval::ValueType
+const vespalib::eval::ValueType &
 TensorAttribute::getTensorType() const
 {
     return getConfig().tensorType();
diff --git a/searchlib/src/vespa/searchlib/tensor/tensor_attribute.h b/searchlib/src/vespa/searchlib/tensor/tensor_attribute.h
index 582fad59828..b88ffcf0f2c 100644
--- a/searchlib/src/vespa/searchlib/tensor/tensor_attribute.h
+++ b/searchlib/src/vespa/searchlib/tensor/tensor_attribute.h
@@ -51,7 +51,7 @@ public:
     const vespalib::eval::Value& get_tensor_ref(uint32_t docid) const override;
     bool supports_extract_dense_view() const override { return false; }
     bool supports_get_tensor_ref() const override { return false; }
-    vespalib::eval::ValueType getTensorType() const override;
+    const vespalib::eval::ValueType & getTensorType() const override;
     void get_state(const vespalib::slime::Inserter& inserter) const override;
     void clearDocs(DocId lidLow, DocId lidLimit) override;
     void onShrinkLidSpace() override;