aboutsummaryrefslogtreecommitdiffstats
path: root/searchlib
diff options
context:
space:
mode:
authorArne Juul <arnej@verizonmedia.com>2020-02-25 08:20:19 +0000
committerArne Juul <arnej@verizonmedia.com>2020-02-25 08:20:19 +0000
commit30fda84e5f61507fb857cf3fbf5af0ad9db69268 (patch)
tree81ff5afff670bb9ce29225eb520d577eb2e13029 /searchlib
parentf1c838e6bb894e7a26203f99aa4c274bb4170baa (diff)
minor fixes after review
Diffstat (limited to 'searchlib')
-rw-r--r--searchlib/src/tests/tensor/hnsw_index/hnsw_index_test.cpp5
-rw-r--r--searchlib/src/vespa/searchlib/tensor/hnsw_index.cpp2
-rw-r--r--searchlib/src/vespa/searchlib/tensor/hnsw_index.h2
3 files changed, 7 insertions, 2 deletions
diff --git a/searchlib/src/tests/tensor/hnsw_index/hnsw_index_test.cpp b/searchlib/src/tests/tensor/hnsw_index/hnsw_index_test.cpp
index 9a7589e1962..52f45860c1e 100644
--- a/searchlib/src/tests/tensor/hnsw_index/hnsw_index_test.cpp
+++ b/searchlib/src/tests/tensor/hnsw_index/hnsw_index_test.cpp
@@ -291,7 +291,12 @@ TEST_F(HnswIndexTest, manual_insert)
HnswNode five{{{1,2}, {4}}};
index->set_node(5, five);
+
+ expect_levels(1, {{3,4,5}});
+ expect_levels(2, {{3,5}});
+ expect_levels(3, {{1,2}});
expect_levels(4, {{1}, {5}});
+ expect_levels(5, {{1,2}, {4}});
}
GTEST_MAIN_RUN_ALL_TESTS()
diff --git a/searchlib/src/vespa/searchlib/tensor/hnsw_index.cpp b/searchlib/src/vespa/searchlib/tensor/hnsw_index.cpp
index 1c62e257d58..54779408b37 100644
--- a/searchlib/src/vespa/searchlib/tensor/hnsw_index.cpp
+++ b/searchlib/src/vespa/searchlib/tensor/hnsw_index.cpp
@@ -372,7 +372,7 @@ HnswIndex::get_node(uint32_t docid) const
}
void
-HnswIndex::set_node(uint32_t docid, HnswNode node)
+HnswIndex::set_node(uint32_t docid, const HnswNode &node)
{
_node_refs.ensure_size(docid + 1, AtomicEntryRef());
// A document cannot be added twice.
diff --git a/searchlib/src/vespa/searchlib/tensor/hnsw_index.h b/searchlib/src/vespa/searchlib/tensor/hnsw_index.h
index a66fdfafbc4..a8129032c11 100644
--- a/searchlib/src/vespa/searchlib/tensor/hnsw_index.h
+++ b/searchlib/src/vespa/searchlib/tensor/hnsw_index.h
@@ -145,7 +145,7 @@ public:
// Should only be used by unit tests.
HnswNode get_node(uint32_t docid) const;
- void set_node(uint32_t docid, HnswNode node);
+ void set_node(uint32_t docid, const HnswNode &node);
};
}