summaryrefslogtreecommitdiffstats
path: root/searchlib
diff options
context:
space:
mode:
authorGeir Storli <geirst@yahooinc.com>2023-03-13 13:55:29 +0000
committerGeir Storli <geirst@yahooinc.com>2023-03-13 13:59:08 +0000
commit0c657642eff7d85c000464e9edba16ded4845e7d (patch)
tree3315f420e49dd85739089780388007ce1649672a /searchlib
parenta40183094fd45dbf320dd57f8d56a5a6fac7f247 (diff)
Reduce creation of Document instances without DocumentTypeRepo.
Diffstat (limited to 'searchlib')
-rw-r--r--searchlib/src/apps/tests/memoryindexstress_test.cpp3
-rw-r--r--searchlib/src/tests/docstore/document_store_visitor/document_store_visitor_test.cpp2
-rw-r--r--searchlib/src/tests/docstore/logdatastore/logdatastore_test.cpp2
-rw-r--r--searchlib/src/vespa/searchlib/test/doc_builder.cpp3
4 files changed, 4 insertions, 6 deletions
diff --git a/searchlib/src/apps/tests/memoryindexstress_test.cpp b/searchlib/src/apps/tests/memoryindexstress_test.cpp
index fb743ad93ac..fdb132d9a36 100644
--- a/searchlib/src/apps/tests/memoryindexstress_test.cpp
+++ b/searchlib/src/apps/tests/memoryindexstress_test.cpp
@@ -153,8 +153,7 @@ makeDoc(const DocumentTypeRepo &repo, uint32_t i,
idstr << "id:test:test:: " << i;
DocumentId id(idstr.str());
const DocumentType *docType = repo.getDocumentType(doc_type_name);
- auto doc(std::make_unique<Document>(*docType, id));
- doc->setRepo(repo);
+ auto doc(std::make_unique<Document>(repo, *docType, id));
if (!titleString.empty()) {
setFieldValue(*doc, title, titleString);
}
diff --git a/searchlib/src/tests/docstore/document_store_visitor/document_store_visitor_test.cpp b/searchlib/src/tests/docstore/document_store_visitor/document_store_visitor_test.cpp
index efe858c016a..e841e334215 100644
--- a/searchlib/src/tests/docstore/document_store_visitor/document_store_visitor_test.cpp
+++ b/searchlib/src/tests/docstore/document_store_visitor/document_store_visitor_test.cpp
@@ -60,7 +60,7 @@ makeDoc(const DocumentTypeRepo &repo, uint32_t i, bool before)
idstr << "id:test:test:: " << i;
DocumentId id(idstr.str());
const DocumentType *docType = repo.getDocumentType(doc_type_name);
- Document::UP doc(new Document(*docType, id));
+ Document::UP doc(new Document(repo, *docType, id));
ASSERT_TRUE(doc.get());
asciistream mainstr;
mainstr << "static text" << i << " body something";
diff --git a/searchlib/src/tests/docstore/logdatastore/logdatastore_test.cpp b/searchlib/src/tests/docstore/logdatastore/logdatastore_test.cpp
index 414e06bd464..580fd199806 100644
--- a/searchlib/src/tests/docstore/logdatastore/logdatastore_test.cpp
+++ b/searchlib/src/tests/docstore/logdatastore/logdatastore_test.cpp
@@ -426,7 +426,7 @@ makeDoc(const DocumentTypeRepo &repo, uint32_t i, bool extra_field, size_t numRe
idstr << "id:test:test:: " << i;
DocumentId id(idstr.str());
const DocumentType *docType = repo.getDocumentType(doc_type_name);
- Document::UP doc(new Document(*docType, id));
+ Document::UP doc(new Document(repo, *docType, id));
ASSERT_TRUE(doc.get());
asciistream mainstr;
mainstr << "static text" << i << " body something";
diff --git a/searchlib/src/vespa/searchlib/test/doc_builder.cpp b/searchlib/src/vespa/searchlib/test/doc_builder.cpp
index 2097cd53b2c..3950a28bea7 100644
--- a/searchlib/src/vespa/searchlib/test/doc_builder.cpp
+++ b/searchlib/src/vespa/searchlib/test/doc_builder.cpp
@@ -59,8 +59,7 @@ DocBuilder::~DocBuilder() = default;
std::unique_ptr<Document>
DocBuilder::make_document(vespalib::string document_id)
{
- auto doc = std::make_unique<Document>(get_document_type(), DocumentId(document_id));
- doc->setRepo(get_repo());
+ auto doc = std::make_unique<Document>(get_repo(), get_document_type(), DocumentId(document_id));
return doc;
}