diff options
| author | Geir Storli <geirst@verizonmedia.com> | 2019-09-04 14:51:41 +0000 |
|---|---|---|
| committer | Geir Storli <geirst@verizonmedia.com> | 2019-09-04 14:51:41 +0000 |
| commit | dd34ad6389712acf165cf4e83cf4901577e06218 (patch) | |
| tree | c45c0654147c72ae500ce822cba1232bdf4b7476 /searchlib | |
| parent | 46aa638f210d1d71c907e2ed9a3911c60dc26ea0 (diff) | |
Pass ConstArrayRef by value.
Diffstat (limited to 'searchlib')
4 files changed, 5 insertions, 5 deletions
diff --git a/searchlib/src/vespa/searchlib/attribute/enumstore.cpp b/searchlib/src/vespa/searchlib/attribute/enumstore.cpp index 0ef0b9d416b..ddd5f8540d1 100644 --- a/searchlib/src/vespa/searchlib/attribute/enumstore.cpp +++ b/searchlib/src/vespa/searchlib/attribute/enumstore.cpp @@ -12,7 +12,7 @@ namespace search { template <> void EnumStoreT<StringEntryType>::writeValues(BufferWriter& writer, - const vespalib::ConstArrayRef<Index>& idxs) const + vespalib::ConstArrayRef<Index> idxs) const { for (const auto& idx : idxs) { const char* src = _store.get(idx); diff --git a/searchlib/src/vespa/searchlib/attribute/enumstore.h b/searchlib/src/vespa/searchlib/attribute/enumstore.h index 4404e67b834..d5fd4904d26 100644 --- a/searchlib/src/vespa/searchlib/attribute/enumstore.h +++ b/searchlib/src/vespa/searchlib/attribute/enumstore.h @@ -232,7 +232,7 @@ public: } // TODO: Change to sending enum indexes as const array ref. - void writeValues(BufferWriter& writer, const vespalib::ConstArrayRef<Index>& idxs) const override; + void writeValues(BufferWriter& writer, vespalib::ConstArrayRef<Index> idxs) const override; bool foldedChange(const Index &idx1, const Index &idx2) const override; bool findEnum(DataType value, IEnumStore::EnumHandle &e) const; std::vector<IEnumStore::EnumHandle> findFoldedEnums(DataType value) const; @@ -256,7 +256,7 @@ class datastore::DataStoreT<IEnumStore::Index>; template <> void EnumStoreT<StringEntryType>::writeValues(BufferWriter& writer, - const vespalib::ConstArrayRef<IEnumStore::Index>& idxs) const; + vespalib::ConstArrayRef<IEnumStore::Index> idxs) const; template <> ssize_t diff --git a/searchlib/src/vespa/searchlib/attribute/enumstore.hpp b/searchlib/src/vespa/searchlib/attribute/enumstore.hpp index ff0f88ff817..ee970a07eef 100644 --- a/searchlib/src/vespa/searchlib/attribute/enumstore.hpp +++ b/searchlib/src/vespa/searchlib/attribute/enumstore.hpp @@ -131,7 +131,7 @@ EnumStoreT<EntryType>::NonEnumeratedLoader::~NonEnumeratedLoader() = default; template <class EntryType> void -EnumStoreT<EntryType>::writeValues(BufferWriter& writer, const vespalib::ConstArrayRef<Index>& idxs) const +EnumStoreT<EntryType>::writeValues(BufferWriter& writer, vespalib::ConstArrayRef<Index> idxs) const { for (const auto& idx : idxs) { writer.write(&_store.get(idx), sizeof(DataType)); diff --git a/searchlib/src/vespa/searchlib/attribute/i_enum_store.h b/searchlib/src/vespa/searchlib/attribute/i_enum_store.h index 3e9e1d2a543..acaa5556cd9 100644 --- a/searchlib/src/vespa/searchlib/attribute/i_enum_store.h +++ b/searchlib/src/vespa/searchlib/attribute/i_enum_store.h @@ -50,7 +50,7 @@ public: virtual ~IEnumStore() = default; - virtual void writeValues(BufferWriter& writer, const vespalib::ConstArrayRef<Index>& idxs) const = 0; + virtual void writeValues(BufferWriter& writer, vespalib::ConstArrayRef<Index> idxs) const = 0; virtual ssize_t load_unique_values(const void* src, size_t available, IndexVector& idx) = 0; virtual void fixupRefCount(Index idx, uint32_t refCount) = 0; virtual void fixupRefCounts(const EnumVector& histogram) = 0; |