Use const reference instead of copying vector.

2 files changed, 7 insertions, 7 deletions

diff --git a/searchlib/src/vespa/searchlib/queryeval/global_filter.cpp b/searchlib/src/vespa/searchlib/queryeval/global_filter.cpp
index 4f2d2f53cdf..ef00d7a3a75 100644
--- a/searchlib/src/vespa/searchlib/queryeval/global_filter.cpp
+++ b/searchlib/src/vespa/searchlib/queryeval/global_filter.cpp
@@ -32,7 +32,7 @@ struct Inactive : GlobalFilter {
 
 struct EmptyFilter : GlobalFilter {
     uint32_t docid_limit;
-    EmptyFilter(uint32_t docid_limit_in) noexcept : docid_limit(docid_limit_in) {}
+    explicit EmptyFilter(uint32_t docid_limit_in) noexcept : docid_limit(docid_limit_in) {}
     ~EmptyFilter() override;
     bool is_active() const override { return true; }
     uint32_t size() const override { return docid_limit; }
@@ -44,7 +44,7 @@ EmptyFilter::~EmptyFilter() = default;
 
 struct BitVectorFilter : public GlobalFilter {
     std::unique_ptr<BitVector> vector;
-    BitVectorFilter(std::unique_ptr<BitVector> vector_in) noexcept
+    explicit BitVectorFilter(std::unique_ptr<BitVector> vector_in) noexcept
       : vector(std::move(vector_in)) {}
     bool is_active() const override { return true; }
     uint32_t size() const override { return vector->size(); }
@@ -82,9 +82,9 @@ struct PartResult {
     std::unique_ptr<BitVector> bits;
     PartResult()
       : matches_any(Trinary::False), bits() {}
-    PartResult(Trinary matches_any_in)
+    explicit PartResult(Trinary matches_any_in)
       : matches_any(matches_any_in), bits() {}
-    PartResult(std::unique_ptr<BitVector> &&bits_in)
+    explicit PartResult(std::unique_ptr<BitVector> &&bits_in)
       : matches_any(Trinary::Undefined), bits(std::move(bits_in)) {}
 };
 
@@ -133,7 +133,7 @@ struct MakePart : Runnable {
             profiler->report(trace->createCursor("global_filter_profiling"));
         }
     }
-    ~MakePart();
+    ~MakePart() override;
 };
 MakePart::~MakePart() = default;
 
@@ -159,7 +159,7 @@ GlobalFilter::create() {
 }
 
 std::shared_ptr<GlobalFilter>
-GlobalFilter::create(std::vector<uint32_t> docids, uint32_t size)
+GlobalFilter::create(const std::vector<uint32_t> & docids, uint32_t size)
 {
     uint32_t prev = 0;
     auto bits = BitVector::create(1, size);
diff --git a/searchlib/src/vespa/searchlib/queryeval/global_filter.h b/searchlib/src/vespa/searchlib/queryeval/global_filter.h
index 12696b767c6..96f3f19b640 100644
--- a/searchlib/src/vespa/searchlib/queryeval/global_filter.h
+++ b/searchlib/src/vespa/searchlib/queryeval/global_filter.h
@@ -39,7 +39,7 @@ public:
     }
 
     static std::shared_ptr<GlobalFilter> create();
-    static std::shared_ptr<GlobalFilter> create(std::vector<uint32_t> docids, uint32_t size);
+    static std::shared_ptr<GlobalFilter> create(const std::vector<uint32_t> & docids, uint32_t size);
     static std::shared_ptr<GlobalFilter> create(std::unique_ptr<BitVector> vector);
     static std::shared_ptr<GlobalFilter> create(std::vector<std::unique_ptr<BitVector>> vectors);
     static std::shared_ptr<GlobalFilter> create(Blueprint &blueprint, uint32_t docid_limit, vespalib::ThreadBundle &thread_bundle, Trace *trace);