Merge pull request #29441 from vespa-engine/jonmv/debug-negative-node-key-in-hits

Log whenever hits are created (FS4, Fast) with negative distribution …

1 files changed, 7 insertions, 0 deletions

diff --git a/searchlib/src/main/java/com/yahoo/searchlib/aggregation/FS4Hit.java b/searchlib/src/main/java/com/yahoo/searchlib/aggregation/FS4Hit.java
index 4a29c98ad89..104cf30e021 100644
--- a/searchlib/src/main/java/com/yahoo/searchlib/aggregation/FS4Hit.java
+++ b/searchlib/src/main/java/com/yahoo/searchlib/aggregation/FS4Hit.java
@@ -6,6 +6,9 @@ import com.yahoo.vespa.objects.Deserializer;
 import com.yahoo.vespa.objects.ObjectVisitor;
 import com.yahoo.vespa.objects.Serializer;
 
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
 /**
  * A single hit from a Vespa content cluster
  *
@@ -13,6 +16,8 @@ import com.yahoo.vespa.objects.Serializer;
  */
 public class FS4Hit extends Hit {
 
+    private static final Logger log = Logger.getLogger(FS4Hit.class.getName());
+
     public static final int classId = registerClass(0x4000 + 95, FS4Hit.class, FS4Hit::new); // shared with c++
     private int path = 0;
     private GlobalId globalId = new GlobalId(new byte[GlobalId.LENGTH]);
@@ -82,6 +87,8 @@ public class FS4Hit extends Hit {
         path = buf.getInt(null);
         globalId = new GlobalId(buf.getBytes(null, GlobalId.LENGTH));
         distributionKey = buf.getInt(null);
+        if (distributionKey < 0)
+            log.log(Level.WARNING, "Distribution key is negative: " + this);
     }
 
     @Override