diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2020-08-12 22:52:32 +0000 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2020-08-13 12:38:58 +0000 |
commit | 92a4b42957394552321a7bb3490e9539cff6992d (patch) | |
tree | 7c8d0ebd7a987f4542fefcff25a7205b86dd0347 /searchsummary/src/tests/docsummary | |
parent | 89414c996e241819648973ab70e34e04bb68447d (diff) |
GC unused code.
Diffstat (limited to 'searchsummary/src/tests/docsummary')
-rw-r--r-- | searchsummary/src/tests/docsummary/matched_elements_filter/matched_elements_filter_test.cpp | 24 |
1 files changed, 16 insertions, 8 deletions
diff --git a/searchsummary/src/tests/docsummary/matched_elements_filter/matched_elements_filter_test.cpp b/searchsummary/src/tests/docsummary/matched_elements_filter/matched_elements_filter_test.cpp index 55c363a12c1..d3712d8a90f 100644 --- a/searchsummary/src/tests/docsummary/matched_elements_filter/matched_elements_filter_test.cpp +++ b/searchsummary/src/tests/docsummary/matched_elements_filter/matched_elements_filter_test.cpp @@ -45,8 +45,8 @@ StructDataType::UP make_struct_elem_type() { auto result = std::make_unique<StructDataType>("elem"); - result->addField(Field("name", *DataType::STRING, true)); - result->addField(Field("weight", *DataType::INT, true)); + result->addField(Field("name", *DataType::STRING)); + result->addField(Field("weight", *DataType::INT)); return result; } @@ -87,8 +87,8 @@ public: _array_type(*_elem_type), _map_type(*DataType::STRING, *_elem_type) { - _doc_type.addField(Field("array_in_doc", _array_type, true)); - _doc_type.addField(Field("map_in_doc", _map_type, true)); + _doc_type.addField(Field("array_in_doc", _array_type)); + _doc_type.addField(Field("map_in_doc", _map_type)); auto* result_class = _config.AddResultClass("test", class_id); EXPECT_TRUE(result_class->AddConfigEntry("array", ResType::RES_JSONSTRING)); @@ -96,7 +96,7 @@ public: EXPECT_TRUE(result_class->AddConfigEntry("map2", ResType::RES_JSONSTRING)); _config.CreateEnumMaps(); } - ~DocsumStore() {} + ~DocsumStore(); const ResultConfig& get_config() const { return _config; } const ResultClass* get_class() const { return _config.LookupResultClass(class_id); } search::docsummary::DocsumStoreValue getMappedDocsum() { @@ -130,6 +130,8 @@ public: } }; +DocsumStore::~DocsumStore() = default; + class AttributeContext : public IAttributeContext { private: AttributeVector::SP _map_value_name; @@ -141,7 +143,7 @@ public: _map2_key(AttributeFactory::createAttribute("map2.key", Config(BasicType::STRING, CollectionType::ARRAY))), _array_weight(AttributeFactory::createAttribute("array.weight", Config(BasicType::INT32, CollectionType::ARRAY))) {} - ~AttributeContext() {} + ~AttributeContext() override; const IAttributeVector* getAttribute(const string&) const override { abort(); } const IAttributeVector* getAttributeStableEnum(const string&) const override { abort(); } void getAttributeList(std::vector<const IAttributeVector*>& list) const override { @@ -153,6 +155,8 @@ public: void asyncForAttribute(const vespalib::string&, std::unique_ptr<search::attribute::IAttributeFunctor>) const override { abort(); } }; +AttributeContext::~AttributeContext() = default; + class StateCallback : public GetDocsumsStateCallback { private: std::string _field_name; @@ -164,7 +168,7 @@ public: _matching_elements(matching_elements) { } - ~StateCallback() {} + ~StateCallback() override; void FillSummaryFeatures(GetDocsumsState*, IDocsumEnvironment*) override {} void FillRankFeatures(GetDocsumsState*, IDocsumEnvironment*) override {} std::unique_ptr<MatchingElements> fill_matching_elements(const MatchingElementsFields&) override { @@ -174,6 +178,8 @@ public: } }; +StateCallback::~StateCallback() = default; + class MatchedElementsFilterTest : public ::testing::Test { private: DocsumStore _doc_store; @@ -201,7 +207,7 @@ public: _fields(std::make_shared<MatchingElementsFields>()) { } - ~MatchedElementsFilterTest() {} + ~MatchedElementsFilterTest(); std::unique_ptr<IDocsumFieldWriter> make_field_writer(const std::string& input_field_name) { int input_field_enum = _doc_store.get_config().GetFieldNameEnum().Lookup(input_field_name.c_str()); return MatchedElementsFilterDFW::create(input_field_name, input_field_enum, @@ -215,6 +221,8 @@ public: const MatchingElementsFields& fields() const { return *_fields; } }; +MatchedElementsFilterTest::~MatchedElementsFilterTest() = default; + TEST_F(MatchedElementsFilterTest, filters_elements_in_array_field_value) { expect_filtered("array", {}, "[]"); |