aboutsummaryrefslogtreecommitdiffstats
path: root/searchsummary/src/tests
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2022-08-29 20:36:08 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2022-08-29 20:50:24 +0000
commit42e56483367aa74845d37ccf28dbb9fe77ce17d7 (patch)
treed8e8b895c3cd8b7535440a4815c455eb72543e2e /searchsummary/src/tests
parente451e225b13d42bc56edbd72426ee76dada35ac5 (diff)
Reduce usage of RawBuf.
Remove some unused code.
Diffstat (limited to 'searchsummary/src/tests')
-rw-r--r--searchsummary/src/tests/docsummary/positionsdfw_test.cpp1
-rw-r--r--searchsummary/src/tests/docsummary/slime_summary/slime_summary_test.cpp24
-rw-r--r--searchsummary/src/tests/docsummary/summary_field_converter/summary_field_converter_test.cpp2
3 files changed, 5 insertions, 22 deletions
diff --git a/searchsummary/src/tests/docsummary/positionsdfw_test.cpp b/searchsummary/src/tests/docsummary/positionsdfw_test.cpp
index 09051e2e9c0..3531efe1798 100644
--- a/searchsummary/src/tests/docsummary/positionsdfw_test.cpp
+++ b/searchsummary/src/tests/docsummary/positionsdfw_test.cpp
@@ -9,7 +9,6 @@
#include <vespa/searchsummary/docsummary/idocsumenvironment.h>
#include <vespa/searchsummary/docsummary/docsumstate.h>
#include <vespa/searchsummary/test/slime_value.h>
-#include <vespa/searchlib/util/rawbuf.h>
#include <vespa/vespalib/testkit/testapp.h>
#include <vespa/vespalib/data/slime/slime.h>
#include <vespa/juniper/rpinterface.h>
diff --git a/searchsummary/src/tests/docsummary/slime_summary/slime_summary_test.cpp b/searchsummary/src/tests/docsummary/slime_summary/slime_summary_test.cpp
index 5e4d375c49f..cab6090da43 100644
--- a/searchsummary/src/tests/docsummary/slime_summary/slime_summary_test.cpp
+++ b/searchsummary/src/tests/docsummary/slime_summary/slime_summary_test.cpp
@@ -17,7 +17,7 @@
#include <vespa/searchsummary/docsummary/keywordextractor.h>
#include <vespa/searchsummary/docsummary/docsum_store_document.h>
#include <vespa/vespalib/data/slime/slime.h>
-#include <vespa/searchlib/util/slime_output_raw_buf_adapter.h>
+#include <vespa/searchlib/util/rawbuf.h>
#include <vespa/vespalib/util/size_literals.h>
using namespace vespalib::slime::convenience;
@@ -41,29 +41,13 @@ using document::StructFieldValue;
namespace {
-struct FieldBlock {
- Slime slime;
- search::RawBuf binary;
-
- explicit FieldBlock(const vespalib::string &jsonInput)
- : slime(), binary(1024)
- {
- size_t used = vespalib::slime::JsonFormat::decode(jsonInput, slime);
- EXPECT_TRUE(used > 0);
- search::SlimeOutputRawBufAdapter adapter(binary);
- vespalib::slime::BinaryFormat::encode(slime, adapter);
- }
- const char *data() const { return binary.GetDrainPos(); }
- size_t dataLen() const { return binary.GetUsedLen(); }
-};
-
struct DocsumFixture : IDocsumStore, GetDocsumsStateCallback {
std::unique_ptr<DynamicDocsumWriter> writer;
StructDataType int_pair_type;
DocumentType doc_type;
GetDocsumsState state;
DocsumFixture();
- ~DocsumFixture();
+ ~DocsumFixture() override;
void getDocsum(Slime &slime) {
uint32_t classId;
search::RawBuf buf(4_Ki);
@@ -111,7 +95,7 @@ DocsumFixture::DocsumFixture()
{
auto config = std::make_unique<ResultConfig>();
ResultClass *cfg = config->AddResultClass("default", 0);
- EXPECT_TRUE(cfg != 0);
+ EXPECT_TRUE(cfg != nullptr);
EXPECT_TRUE(cfg->AddConfigEntry("int_field", RES_INT));
EXPECT_TRUE(cfg->AddConfigEntry("short_field", RES_SHORT));
EXPECT_TRUE(cfg->AddConfigEntry("byte_field", RES_BYTE));
@@ -140,7 +124,7 @@ DocsumFixture::DocsumFixture()
doc_type.addField(Field("longdata_field", *DataType::RAW));
doc_type.addField(Field("int_pair_field", int_pair_type));
}
-DocsumFixture::~DocsumFixture() {}
+DocsumFixture::~DocsumFixture() = default;
} // namespace <unnamed>
diff --git a/searchsummary/src/tests/docsummary/summary_field_converter/summary_field_converter_test.cpp b/searchsummary/src/tests/docsummary/summary_field_converter/summary_field_converter_test.cpp
index c6f310f2d53..1d7795d26dc 100644
--- a/searchsummary/src/tests/docsummary/summary_field_converter/summary_field_converter_test.cpp
+++ b/searchsummary/src/tests/docsummary/summary_field_converter/summary_field_converter_test.cpp
@@ -132,7 +132,7 @@ FieldBlock::FieldBlock(const vespalib::string &jsonInput)
vespalib::slime::BinaryFormat::encode(slime, adapter);
}
-FieldBlock::~FieldBlock() {}
+FieldBlock::~FieldBlock() = default;
class Test : public vespalib::TestApp {
std::unique_ptr<Schema> _schema;