diff options
author | Bjørn Christian Seime <bjorncs@oath.com> | 2018-11-26 14:33:47 +0100 |
---|---|---|
committer | Bjørn Christian Seime <bjorncs@oath.com> | 2018-11-26 14:33:47 +0100 |
commit | 5fda15658e85d4c0bf7c52e9afa07a6aae072c25 (patch) | |
tree | 72d93006016382b0ba4dd1264add481667984442 /security-utils | |
parent | 2e6f1bbac52aa20856ee8feaefd810360298d0b3 (diff) |
Allow empty 'required-credentials'
Diffstat (limited to 'security-utils')
2 files changed, 3 insertions, 3 deletions
diff --git a/security-utils/src/main/java/com/yahoo/security/tls/json/TransportSecurityOptionsEntity.java b/security-utils/src/main/java/com/yahoo/security/tls/json/TransportSecurityOptionsEntity.java index bcd5b193493..fbb98d7c382 100644 --- a/security-utils/src/main/java/com/yahoo/security/tls/json/TransportSecurityOptionsEntity.java +++ b/security-utils/src/main/java/com/yahoo/security/tls/json/TransportSecurityOptionsEntity.java @@ -5,7 +5,6 @@ import com.fasterxml.jackson.annotation.JsonIgnoreProperties; import com.fasterxml.jackson.annotation.JsonInclude; import com.fasterxml.jackson.annotation.JsonProperty; -import java.util.ArrayList; import java.util.List; import static com.fasterxml.jackson.annotation.JsonInclude.Include.NON_EMPTY; @@ -28,7 +27,7 @@ class TransportSecurityOptionsEntity { } static class AuthorizedPeer { - @JsonProperty("required-credentials") List<RequiredCredential> requiredCredentials = new ArrayList<>(); + @JsonProperty("required-credentials") List<RequiredCredential> requiredCredentials; @JsonProperty("name") String name; @JsonProperty("roles") @JsonInclude(NON_EMPTY) List<String> roles; } diff --git a/security-utils/src/main/java/com/yahoo/security/tls/json/TransportSecurityOptionsJsonSerializer.java b/security-utils/src/main/java/com/yahoo/security/tls/json/TransportSecurityOptionsJsonSerializer.java index cfabd81cf44..f75cb4bcfff 100644 --- a/security-utils/src/main/java/com/yahoo/security/tls/json/TransportSecurityOptionsJsonSerializer.java +++ b/security-utils/src/main/java/com/yahoo/security/tls/json/TransportSecurityOptionsJsonSerializer.java @@ -83,7 +83,7 @@ public class TransportSecurityOptionsJsonSerializer { if (authorizedPeer.name == null) { throw missingFieldException("name"); } - if (authorizedPeer.requiredCredentials.isEmpty()) { + if (authorizedPeer.requiredCredentials == null) { throw missingFieldException("required-credentials"); } return new PeerPolicy(authorizedPeer.name, toRoles(authorizedPeer.roles), toRequestPeerCredentials(authorizedPeer.requiredCredentials)); @@ -131,6 +131,7 @@ public class TransportSecurityOptionsJsonSerializer { for (PeerPolicy peerPolicy : authorizedPeers.peerPolicies()) { AuthorizedPeer authorizedPeer = new AuthorizedPeer(); authorizedPeer.name = peerPolicy.policyName(); + authorizedPeer.requiredCredentials = new ArrayList<>(); for (RequiredPeerCredential requiredPeerCredential : peerPolicy.requiredCredentials()) { RequiredCredential requiredCredential = new RequiredCredential(); requiredCredential.field = toField(requiredPeerCredential.field()); |