summaryrefslogtreecommitdiffstats
path: root/security-utils
diff options
context:
space:
mode:
authorBjørn Christian Seime <bjorncs@verizonmedia.com>2019-07-02 15:21:04 +0200
committerBjørn Christian Seime <bjorncs@verizonmedia.com>2019-07-03 15:15:56 +0200
commit11a5942edc867ef783568e0c5f43c571895232d1 (patch)
treec53cbe88817c179dec6ca2bfe3b3dd48e34d4419 /security-utils
parent76f07e1fdafcda1bcf1c178b2fc8d32b30d9b681 (diff)
Rename 'ReloadingTlsContext' -> 'ConfigFiledBasedTlsContext'
Diffstat (limited to 'security-utils')
-rw-r--r--security-utils/src/main/java/com/yahoo/security/tls/ConfigFiledBasedTlsContext.java (renamed from security-utils/src/main/java/com/yahoo/security/tls/ReloadingTlsContext.java)9
-rw-r--r--security-utils/src/main/java/com/yahoo/security/tls/TransportSecurityUtils.java2
-rw-r--r--security-utils/src/test/java/com/yahoo/security/tls/ConfigFiledBasedTlsContextTest.java (renamed from security-utils/src/test/java/com/yahoo/security/tls/ReloadingTlsContextTest.java)4
3 files changed, 8 insertions, 7 deletions
diff --git a/security-utils/src/main/java/com/yahoo/security/tls/ReloadingTlsContext.java b/security-utils/src/main/java/com/yahoo/security/tls/ConfigFiledBasedTlsContext.java
index 7e60abb2ee6..c30f92cec63 100644
--- a/security-utils/src/main/java/com/yahoo/security/tls/ReloadingTlsContext.java
+++ b/security-utils/src/main/java/com/yahoo/security/tls/ConfigFiledBasedTlsContext.java
@@ -31,20 +31,21 @@ import java.util.logging.Level;
import java.util.logging.Logger;
/**
- * A {@link TlsContext} that regularly reloads the credentials referred to from the transport security options file.
+ * A {@link TlsContext} that uses the tls configuration specified in the transport security options file.
+ * The credentials are regularly reloaded to support short-lived certificates.
*
* @author bjorncs
*/
-public class ReloadingTlsContext implements TlsContext {
+public class ConfigFiledBasedTlsContext implements TlsContext {
private static final Duration UPDATE_PERIOD = Duration.ofHours(1);
- private static final Logger log = Logger.getLogger(ReloadingTlsContext.class.getName());
+ private static final Logger log = Logger.getLogger(ConfigFiledBasedTlsContext.class.getName());
private final TlsContext tlsContext;
private final ScheduledExecutorService scheduler = Executors.newSingleThreadScheduledExecutor(new ReloaderThreadFactory());
- public ReloadingTlsContext(Path tlsOptionsConfigFile, AuthorizationMode mode) {
+ public ConfigFiledBasedTlsContext(Path tlsOptionsConfigFile, AuthorizationMode mode) {
TransportSecurityOptions options = TransportSecurityOptions.fromJsonFile(tlsOptionsConfigFile);
MutableX509TrustManager trustManager = new MutableX509TrustManager();
MutableX509KeyManager keyManager = new MutableX509KeyManager();
diff --git a/security-utils/src/main/java/com/yahoo/security/tls/TransportSecurityUtils.java b/security-utils/src/main/java/com/yahoo/security/tls/TransportSecurityUtils.java
index a4e508e0d2a..514a538f0f9 100644
--- a/security-utils/src/main/java/com/yahoo/security/tls/TransportSecurityUtils.java
+++ b/security-utils/src/main/java/com/yahoo/security/tls/TransportSecurityUtils.java
@@ -66,7 +66,7 @@ public class TransportSecurityUtils {
public static Optional<TlsContext> createTlsContext() {
return getConfigFile()
- .map(configFile -> new ReloadingTlsContext(configFile, getInsecureAuthorizationMode()));
+ .map(configFile -> new ConfigFiledBasedTlsContext(configFile, getInsecureAuthorizationMode()));
}
private static Optional<String> getEnvironmentVariable(Map<String, String> environmentVariables, String variableName) {
diff --git a/security-utils/src/test/java/com/yahoo/security/tls/ReloadingTlsContextTest.java b/security-utils/src/test/java/com/yahoo/security/tls/ConfigFiledBasedTlsContextTest.java
index bcdb0793348..5b0fcfc9d65 100644
--- a/security-utils/src/test/java/com/yahoo/security/tls/ReloadingTlsContextTest.java
+++ b/security-utils/src/test/java/com/yahoo/security/tls/ConfigFiledBasedTlsContextTest.java
@@ -26,7 +26,7 @@ import static org.assertj.core.api.Assertions.assertThat;
/**
* @author bjorncs
*/
-public class ReloadingTlsContextTest {
+public class ConfigFiledBasedTlsContextTest {
@Rule
public TemporaryFolder tempDirectory = new TemporaryFolder();
@@ -55,7 +55,7 @@ public class ReloadingTlsContextTest {
Path optionsFile = tempDirectory.newFile().toPath();
options.toJsonFile(optionsFile);
- try (TlsContext tlsContext = new ReloadingTlsContext(optionsFile, AuthorizationMode.ENFORCE)) {
+ try (TlsContext tlsContext = new ConfigFiledBasedTlsContext(optionsFile, AuthorizationMode.ENFORCE)) {
SSLEngine sslEngine = tlsContext.createSslEngine();
assertThat(sslEngine).isNotNull();
String[] enabledCiphers = sslEngine.getEnabledCipherSuites();