summaryrefslogtreecommitdiffstats
path: root/slobrok
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2020-11-12 10:00:51 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2020-11-12 10:00:51 +0000
commitad3d289e62bc0e6e46ee8f1173c29c4ac9ad0c70 (patch)
treee3791bc7b1c2bd39719700d9798cd97cbcb4cabc /slobrok
parent4ab1c5903a1f5f1d3c8fd8a8cec802e5e0ab4a73 (diff)
Add some more info to error messages to ease debugging.
Diffstat (limited to 'slobrok')
-rw-r--r--slobrok/src/vespa/slobrok/server/rpc_server_manager.cpp9
1 files changed, 5 insertions, 4 deletions
diff --git a/slobrok/src/vespa/slobrok/server/rpc_server_manager.cpp b/slobrok/src/vespa/slobrok/server/rpc_server_manager.cpp
index e3d7800f236..2b1e71a0d36 100644
--- a/slobrok/src/vespa/slobrok/server/rpc_server_manager.cpp
+++ b/slobrok/src/vespa/slobrok/server/rpc_server_manager.cpp
@@ -11,6 +11,8 @@
#include <vespa/log/log.h>
LOG_SETUP(".rpcserver");
+using vespalib::make_string_short::fmt;
+
namespace slobrok {
RpcServerManager::RpcServerManager(SBEnv &sbenv)
@@ -128,9 +130,8 @@ RpcServerManager::addMyReservation(const std::string & name, const std::string &
// was alright already
return OkState(0, "already registered");
} else {
- return OkState(FRTE_RPC_METHOD_FAILED, vespalib::make_string(
- "name %s registered (to %s), cannot register %s",
- name.c_str(), old->getSpec().c_str(), spec.c_str()));
+ return OkState(FRTE_RPC_METHOD_FAILED, fmt("name %s registered (to %s), cannot register %s",
+ name.c_str(), old->getSpec().c_str(), spec.c_str()));
}
}
@@ -229,7 +230,7 @@ RpcServerManager::removeLocal(const std::string & name, const std::string &spec)
if (rpcsrv->getSpec() != spec) {
// the client can probably ignore this "error"
// or log it on level INFO?
- return OkState(1, "name registered, but with different spec");
+ return OkState(1, fmt("name registered, but with different spec (%s)", rpcsrv->getSpec().c_str()));
}
auto tdUP = _rpcsrvmap.remove(name);
LOG_ASSERT(tdUP.get() == rpcsrv);