diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2016-06-23 20:51:37 +0000 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2016-06-23 20:51:37 +0000 |
commit | 13748c9468b6b3f00726cba5eab91df151604fd5 (patch) | |
tree | 3308cab837eb0fa1f1deef76cbd54f4843a424b5 /slobrok | |
parent | 521f3b8266a1386c44550ceac93a8a41a5ba4f4d (diff) |
This one will never trigger....
I got this one with gcc 6.1.
/home/balder/git/vespa/slobrok/src/vespa/slobrok/server/rpchooks.cpp: In member function 'void slobrok::RPCHooks::rpc_wantAdd(FRT_RPCRequest*)':
/home/balder/git/vespa/slobrok/src/vespa/slobrok/server/rpchooks.cpp:355:24: error: comparison of constant '1' with boolean expression is always false [-Werror=bool-compare]
if (state.failed() > 1) {
~~~~~~~~~~~~~~~^~~
Diffstat (limited to 'slobrok')
-rw-r--r-- | slobrok/src/vespa/slobrok/server/rpchooks.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/slobrok/src/vespa/slobrok/server/rpchooks.cpp b/slobrok/src/vespa/slobrok/server/rpchooks.cpp index 53d8eb2423a..5f610ae2e45 100644 --- a/slobrok/src/vespa/slobrok/server/rpchooks.cpp +++ b/slobrok/src/vespa/slobrok/server/rpchooks.cpp @@ -352,7 +352,7 @@ RPCHooks::rpc_wantAdd(FRT_RPCRequest *req) const char *dSpec = args[2]._string._str; FRT_Values &retval = *req->GetReturn(); OkState state = _rpcsrvmanager.addRemReservation(remsb, dName, dSpec); - if (state.failed() > 1) { + if (state.failed()) { req->SetError(FRTE_RPC_METHOD_FAILED, state.errorMsg.c_str()); } retval.AddInt32(state.errorCode); |