summaryrefslogtreecommitdiffstats
path: root/staging_vespalib
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2016-12-01 03:51:12 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2016-12-12 02:55:41 +0100
commit24cb878af1ec770f075f6ccfd582dcceb146cb14 (patch)
tree3aafbab8ec50b9afb59c3120806eac8140a561f2 /staging_vespalib
parenta549d1ded94e3e79046ce5c7a96e5c29b83eae5c (diff)
No need to cast when using value transfer.
Diffstat (limited to 'staging_vespalib')
-rw-r--r--staging_vespalib/src/tests/xmlserializable/xmlserializabletest.cpp10
1 files changed, 3 insertions, 7 deletions
diff --git a/staging_vespalib/src/tests/xmlserializable/xmlserializabletest.cpp b/staging_vespalib/src/tests/xmlserializable/xmlserializabletest.cpp
index f07749b0104..a44802735eb 100644
--- a/staging_vespalib/src/tests/xmlserializable/xmlserializabletest.cpp
+++ b/staging_vespalib/src/tests/xmlserializable/xmlserializabletest.cpp
@@ -30,17 +30,15 @@ Test::Main()
TEST_DONE();
}
-
void
Test::testNormalUsage()
{
- const char * UP = "up";
std::ostringstream ost;
XmlOutputStream xos(ost);
using namespace vespalib::xml;
xos << XmlTag("car")
<< XmlTag("door")
- << XmlAttribute("windowstate", UP)
+ << XmlAttribute("windowstate", "up")
<< XmlEndTag()
<< XmlTag("description")
<< "This is a car description used to test"
@@ -57,13 +55,12 @@ Test::testNormalUsage()
void
Test::testEscaping()
{
- const char * P100 = "<100%\" &\n>";
std::ostringstream ost;
XmlOutputStream xos(ost);
using namespace vespalib::xml;
xos << XmlTag("!#trash%-", CONVERT_ILLEGAL_CHARACTERS)
<< XmlTag("foo")
- << XmlAttribute("bar", P100)
+ << XmlAttribute("bar", "<100%\" &\n>")
<< XmlEndTag()
<< XmlTag("escaped")
<< XmlEscapedContent()
@@ -92,14 +89,13 @@ Test::testEscaping()
}
namespace {
- const char * BLUE = "blue";
struct LookAndFeel : public XmlSerializable {
LookAndFeel() {}
void printXml(XmlOutputStream& out) const {
using namespace vespalib::xml;
- out << XmlAttribute("color", BLUE)
+ out << XmlAttribute("color", "blue")
<< XmlTag("other")
<< XmlAttribute("count", 5)
<< XmlTag("something") << "foo" << XmlEndTag()