Only let reindexing puts through locked bucket if their token matches that of the lock

Avoids race condition edge case where reindexing puts from an outdated
visitor may pass through a bucket lock intended for a newly created
visitor operation

Tokens are 128-bit values derived from a CSPRNG, so uniqueness is for
all intents and purposes guaranteed.

1 files changed, 1 insertions, 1 deletions

diff --git a/storage/src/tests/distributor/mergeoperationtest.cpp b/storage/src/tests/distributor/mergeoperationtest.cpp
index 852c2ef8754..90fcf40b3fe 100644
--- a/storage/src/tests/distributor/mergeoperationtest.cpp
+++ b/storage/src/tests/distributor/mergeoperationtest.cpp
@@ -422,7 +422,7 @@ TEST_F(MergeOperationTest, merge_operation_is_blocked_by_locked_bucket) {
     op.setIdealStateManager(&getIdealStateManager());
 
     EXPECT_FALSE(op.isBlocked(*_pendingTracker, _operation_sequencer));
-    auto token = _operation_sequencer.try_acquire(makeDocumentBucket(document::BucketId(16, 1)));
+    auto token = _operation_sequencer.try_acquire(makeDocumentBucket(document::BucketId(16, 1)), "foo");
     EXPECT_TRUE(token.valid());
     EXPECT_TRUE(op.isBlocked(*_pendingTracker, _operation_sequencer));
 }