diff options
author | Tor Brede Vekterli <vekterli@yahoo-inc.com> | 2016-12-06 13:45:06 +0100 |
---|---|---|
committer | Tor Brede Vekterli <vekterli@yahoo-inc.com> | 2016-12-06 13:45:06 +0100 |
commit | ba1bd01788166317d75805b976475297ce9794c7 (patch) | |
tree | ca26c0dbff83348500ef52194c141ccd70aa3869 /storage/src/tests/distributor/visitoroperationtest.cpp | |
parent | 7bc5edc9a3e9e7b998eb0def3930fc4ea9a72ac1 (diff) |
Add clarifying comment on metric update testing
Diffstat (limited to 'storage/src/tests/distributor/visitoroperationtest.cpp')
-rw-r--r-- | storage/src/tests/distributor/visitoroperationtest.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/storage/src/tests/distributor/visitoroperationtest.cpp b/storage/src/tests/distributor/visitoroperationtest.cpp index 055fe9b9ab9..7bd9eea29b0 100644 --- a/storage/src/tests/distributor/visitoroperationtest.cpp +++ b/storage/src/tests/distributor/visitoroperationtest.cpp @@ -1674,6 +1674,9 @@ VisitorOperationTest::statistical_metrics_not_updated_on_wrong_distribution() "ReturnCode(WRONG_DISTRIBUTION, distributor:100 storage:2)"), runEmptyVisitor(createVisitorCommand("wrongdist", id, nullId))); + // Note that we're testing the number of _times_ the metric has been + // updated, not the value with which it's been updated (which would be zero + // even in the case we actually did update the statistical metrics). CPPUNIT_ASSERT_EQUAL(int64_t(0), defaultVisitorMetrics().buckets_per_visitor.getCount()); CPPUNIT_ASSERT_EQUAL(int64_t(0), defaultVisitorMetrics().docs_per_visitor.getCount()); CPPUNIT_ASSERT_EQUAL(int64_t(0), defaultVisitorMetrics().bytes_per_visitor.getCount()); |