summaryrefslogtreecommitdiffstats
path: root/storage/src/tests/distributor
diff options
context:
space:
mode:
authorTor Brede Vekterli <vekterli@yahooinc.com>2021-09-16 09:35:47 +0000
committerTor Brede Vekterli <vekterli@yahooinc.com>2021-09-16 09:35:47 +0000
commiteb919eea47c96c09977ebc0a68ed6780f95eb75b (patch)
tree515a588ecfcac7249568dc93e521e3c7051a5270 /storage/src/tests/distributor
parent5d492755b49433c1ef6d77c78b43b9759e26b5c9 (diff)
Aggregate pending operation stats across all stripes in stripe guard
Diffstat (limited to 'storage/src/tests/distributor')
-rw-r--r--storage/src/tests/distributor/multi_thread_stripe_access_guard_test.cpp20
1 files changed, 20 insertions, 0 deletions
diff --git a/storage/src/tests/distributor/multi_thread_stripe_access_guard_test.cpp b/storage/src/tests/distributor/multi_thread_stripe_access_guard_test.cpp
index ba28396886f..07005aa898b 100644
--- a/storage/src/tests/distributor/multi_thread_stripe_access_guard_test.cpp
+++ b/storage/src/tests/distributor/multi_thread_stripe_access_guard_test.cpp
@@ -18,6 +18,7 @@ namespace storage::distributor {
struct AggregationTestingMockTickableStripe : MockTickableStripe {
PotentialDataLossReport report;
std::vector<dbtransition::Entry> entries;
+ StripeAccessGuard::PendingOperationStats pending_stats{0, 0};
PotentialDataLossReport remove_superfluous_buckets(document::BucketSpace, const lib::ClusterState&, bool) override {
return report;
@@ -38,6 +39,10 @@ struct AggregationTestingMockTickableStripe : MockTickableStripe {
return result;
}
+ StripeAccessGuard::PendingOperationStats pending_operation_stats() const override {
+ return pending_stats;
+ }
+
bool tick() override {
return false;
}
@@ -96,6 +101,21 @@ TEST_F(MultiThreadedStripeAccessGuardTest, remove_superfluous_buckets_aggregates
EXPECT_EQ(report.documents, 680);
}
+TEST_F(MultiThreadedStripeAccessGuardTest, pending_operation_stats_aggregates_stats_across_stripes) {
+ using Stats = StripeAccessGuard::PendingOperationStats;
+ _stripe0.pending_stats = Stats(20, 100);
+ _stripe1.pending_stats = Stats(5, 200);
+ _stripe2.pending_stats = Stats(7, 350);
+ _stripe3.pending_stats = Stats(3, 30);
+ start_pool_with_stripes();
+
+ auto guard = _accessor.rendezvous_and_hold_all();
+ auto pending_stats = guard->pending_operation_stats();
+
+ EXPECT_EQ(pending_stats.external_load_operations, 35);
+ EXPECT_EQ(pending_stats.maintenance_operations, 680);
+}
+
TEST_F(MultiThreadedStripeAccessGuardTest, merge_entries_into_db_operates_across_all_stripes) {
start_pool_with_stripes();
// Note: The bucket key is calculated by reversing the bits of the raw bucket id.