summaryrefslogtreecommitdiffstats
path: root/storage/src/tests/persistence/persistencetestutils.cpp
diff options
context:
space:
mode:
authorHarald Musum <musum@verizonmedia.com>2020-05-04 21:30:38 +0200
committerGitHub <noreply@github.com>2020-05-04 21:30:38 +0200
commit24dc7f48d253f9cb6b69ba9a58bf53cf789803c4 (patch)
tree7bfcb6eb321f8d6a5fe171f729ce3e5867d84e40 /storage/src/tests/persistence/persistencetestutils.cpp
parent6e07be846490ce9579f29d4a5de47ca86cea430a (diff)
Revert "- Implement async put"
Diffstat (limited to 'storage/src/tests/persistence/persistencetestutils.cpp')
-rw-r--r--storage/src/tests/persistence/persistencetestutils.cpp23
1 files changed, 6 insertions, 17 deletions
diff --git a/storage/src/tests/persistence/persistencetestutils.cpp b/storage/src/tests/persistence/persistencetestutils.cpp
index f2c7b317be2..4ac9dfd7765 100644
--- a/storage/src/tests/persistence/persistencetestutils.cpp
+++ b/storage/src/tests/persistence/persistencetestutils.cpp
@@ -12,7 +12,6 @@
#include <vespa/vespalib/io/fileutil.h>
#include <vespa/vespalib/objects/nbostream.h>
#include <vespa/vespalib/util/exceptions.h>
-#include <vespa/vespalib/util/sequencedtaskexecutor.h>
using document::DocumentType;
using storage::spi::test::makeSpiBucket;
@@ -55,9 +54,9 @@ PersistenceTestEnvironment::PersistenceTestEnvironment(DiskCount numDisks, const
{
_node.setupDummyPersistence();
_metrics.initDiskMetrics(numDisks, _node.getLoadTypes()->getMetricLoadTypes(), 1, 1);
- _handler = std::make_unique<FileStorHandler>(_messageKeeper, _metrics,
+ _handler.reset(new FileStorHandler(_messageKeeper, _metrics,
_node.getPersistenceProvider().getPartitionStates().getList(),
- _node.getComponentRegister());
+ _node.getComponentRegister()));
for (uint32_t i = 0; i < numDisks; i++) {
_diskEnvs.push_back(
std::make_unique<PersistenceUtil>(_config.getConfigId(), _node.getComponentRegister(), *_handler,
@@ -65,10 +64,6 @@ PersistenceTestEnvironment::PersistenceTestEnvironment(DiskCount numDisks, const
}
}
-PersistenceTestEnvironment::~PersistenceTestEnvironment() {
- _handler->close();
-}
-
PersistenceTestUtils::PersistenceTestUtils() = default;
PersistenceTestUtils::~PersistenceTestUtils() = default;
@@ -79,21 +74,15 @@ PersistenceTestUtils::dumpBucket(const document::BucketId& bid, uint16_t disk) {
void
PersistenceTestUtils::setupDisks(uint32_t numDisks) {
- _env = std::make_unique<PersistenceTestEnvironment>(DiskCount(numDisks), "todo-make-unique-persistencetestutils");
- setupExecutor(numDisks);
-}
-
-void
-PersistenceTestUtils::setupExecutor(uint32_t numThreads) {
- _sequenceTaskExecutor = vespalib::SequencedTaskExecutor::create(numThreads, 1000, vespalib::Executor::OptimizeFor::ADAPTIVE);
+ _env.reset(new PersistenceTestEnvironment(DiskCount(numDisks), "todo-make-unique-persistencetestutils"));
}
std::unique_ptr<PersistenceThread>
PersistenceTestUtils::createPersistenceThread(uint32_t disk)
{
- return std::make_unique<PersistenceThread>(_sequenceTaskExecutor.get(), _env->_node.getComponentRegister(),
- _env->_config.getConfigId(),getPersistenceProvider(),
- getEnv()._fileStorHandler, getEnv()._metrics, disk);
+ return std::make_unique<PersistenceThread>(_env->_node.getComponentRegister(), _env->_config.getConfigId(),
+ getPersistenceProvider(), getEnv()._fileStorHandler,
+ getEnv()._metrics, disk);
}
document::Document::SP